Merge lp:~tpeeters/ubuntu-ui-toolkit/30-landscapeToolbar into lp:ubuntu-ui-toolkit/staging

Proposed by Tim Peeters
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1775
Merged at revision: 1775
Proposed branch: lp:~tpeeters/ubuntu-ui-toolkit/30-landscapeToolbar
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 20 lines (+3/-1)
1 file modified
src/Ubuntu/Components/Themes/Ambiance/1.3/ToolbarStyle.qml (+3/-1)
To merge this branch: bzr merge lp:~tpeeters/ubuntu-ui-toolkit/30-landscapeToolbar
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+280695@code.launchpad.net

Commit message

Reduce toolbar height on phone in landscape orientation.

Description of the change

Reviewed visuals on phone with Olga, Ben at the sprint.

To post a comment you must log in.
1775. By Tim Peeters

link bug

Revision history for this message
Zsombor Egri (zsombi) wrote :

Pretty mucha no-brainer :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/ToolbarStyle.qml'
2--- src/Ubuntu/Components/Themes/Ambiance/1.3/ToolbarStyle.qml 2015-12-15 13:41:28 +0000
3+++ src/Ubuntu/Components/Themes/Ambiance/1.3/ToolbarStyle.qml 2015-12-16 10:53:56 +0000
4@@ -14,13 +14,15 @@
5 * along with this program. If not, see <http://www.gnu.org/licenses/>.
6 */
7 import QtQuick 2.4
8+import QtQuick.Window 2.2
9 import Ubuntu.Components 1.3
10 import Ubuntu.Components.Styles 1.3 as Style
11
12 Style.ToolbarStyle {
13 id: toolbarStyle
14 implicitWidth: parent ? parent.width : 0
15- implicitHeight: units.gu(4)
16+ // reduce toolbar height on phone in landscape orientation:
17+ implicitHeight: Screen.height > units.gu(50) ? units.gu(4) : units.gu(3)
18
19 /*!
20 The default action delegate if the styled item does

Subscribers

People subscribed via source and target branches