Merge lp:~tpeeters/notes-app/remove_get_header into lp:notes-app

Proposed by Tim Peeters
Status: Approved
Approved by: Olivier Tilloy
Approved revision: 268
Proposed branch: lp:~tpeeters/notes-app/remove_get_header
Merge into: lp:notes-app
Diff against target: 12 lines (+0/-3)
1 file modified
tests/autopilot/notes_app/emulators/notesapp.py (+0/-3)
To merge this branch: bzr merge lp:~tpeeters/notes-app/remove_get_header
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
Leo Arias (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+223218@code.launchpad.net

Commit message

Remove the autopilot emulators get_header() function which overrides the same function from the UI toolkit.

Description of the change

Remove the autopilot emulators get_header() function which overrides the same function from the UI toolkit.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
268. By Tim Peeters

empty commit to push jenkins

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

Looks good. The error comes from autopilot:
https://bugs.launchpad.net/autopilot/+bug/1327377

Ready to be released.

review: Approve
Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM.

review: Approve
269. By Tim Peeters

merge trunk

Unmerged revisions

269. By Tim Peeters

merge trunk

268. By Tim Peeters

empty commit to push jenkins

267. By Tim Peeters

remove get_header() which overrides the one from uitk cpos

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/notes_app/emulators/notesapp.py'
2--- tests/autopilot/notes_app/emulators/notesapp.py 2013-11-19 19:30:40 +0000
3+++ tests/autopilot/notes_app/emulators/notesapp.py 2014-09-09 20:44:42 +0000
4@@ -17,9 +17,6 @@
5 notes.sort(key=lambda note: note.y)
6 return notes
7
8- def get_header(self):
9- return self.select_single("Header")
10-
11 def get_note_content(self, note_item):
12 return note_item.select_single("MixedEdit")
13

Subscribers

People subscribed via source and target branches