Merge lp:~tpeeters/messaging-app/ap-get-header into lp:messaging-app

[Tim Peeters]

remove the get_header() function.

remove the get_header() function.
It is already implemented in the UITK custom-proxy-objects, and it will change internally. Your function would break then.

[Leo Arias (elopio)]

Yes, it's redundant.

review: Approve (~)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:109
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/216/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/638
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-touch/158/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/10/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/10
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/568
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/777
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/777/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1314
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1314/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6799/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8125

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/216/rebuild

review: Needs Fixing (continuous-integration)

[lp:~tpeeters/messaging-app/ap-get-header]

110. By Tim Peeters on 2014-06-05

kick jenkins

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:110
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/217/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/648
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-touch/159/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/11
        deb: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/11/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/11
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/576
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/787
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/787/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1329
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1329/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6800/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8136

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/217/rebuild

review: Needs Fixing (continuous-integration)

[Tiago Salem Herrmann (tiagosh)]

thanks! looks good.
can you add the checklist so we can top approve?

review: Approve

=== modified file 'tests/autopilot/messaging_app/emulators.py'
--- tests/autopilot/messaging_app/emulators.py	2014-04-07 21:06:51 +0000
+++ tests/autopilot/messaging_app/emulators.py	2014-06-05 18:54:28 +0000
@@ -164,11 +164,6 @@
             objectName='contactCallButton',
         )
 
-    def get_header(self):
-        """return header object"""
-
-        return self.select_single('Header', objectName='MainView_Header')
-
     def get_dialog_buttons(self, visible=True):
         """Return DialogButtons