Unity

Merge lp:~townsend/unity/revert-keyboard-nav-glow into lp:unity

  1. revert-keyboard-nav-glow
  2. Merge into trunk
Proposed by Christopher Townsend
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3285
Proposed branch: lp:~townsend/unity/revert-keyboard-nav-glow
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
unity-shared/IconRenderer.cpp (+1/-1)
To merge this branch: bzr merge lp:~townsend/unity/revert-keyboard-nav-glow
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email: mp+157674@code.launchpad.net

Commit message

Revert the glow intensity of icons in keyboard navigation mode due to a visual regression in the Switcher icons.

Description of the change

Commit revno. 3274 also affected the glow around icons in the Switcher, which was unintended. This MP reverts that behavior to use the original value for glow intensity when using keyboard navigation mode.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'unity-shared/IconRenderer.cpp'
2--- unity-shared/IconRenderer.cpp 2013-04-03 15:28:30 +0000
3+++ unity-shared/IconRenderer.cpp 2013-04-08 15:29:24 +0000
4@@ -485,7 +485,7 @@
5 colorify = nux::color::White;
6 background_tile_colorify = nux::color::White;
7 backlight_intensity = 0.95f;
8- glow_intensity = 1.3f;
9+ glow_intensity = 1.0f;
10 shadow_intensity = 0.0f;
11
12 background = textures_->icon_selected_background[size];