Merge lp:~townsend/unity/fix_lp765732 into lp:unity
Proposed by
Christopher Townsend
Status: | Merged |
---|---|
Approved by: | Brandon Schaefer |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3213 |
Proposed branch: | lp:~townsend/unity/fix_lp765732 |
Merge into: | lp:unity |
Diff against target: |
216 lines (+127/-20) 4 files modified
launcher/Launcher.cpp (+14/-18) launcher/Launcher.h (+0/-2) tests/autopilot/unity/emulators/launcher.py (+21/-0) tests/autopilot/unity/tests/launcher/test_scroll.py (+92/-0) |
To merge this branch: | bzr merge lp:~townsend/unity/fix_lp765732 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Brandon Schaefer (community) | Approve | ||
Thomi Richards (community) | Needs Fixing | ||
Review via email:
|
Commit message
Add the ability to progressively autoscroll the Launcher when there are stacked icons.
Description of the change
This adds to ability to progressively autoscroll when there are enough icons to be stacked and the mouse cursor is within the 24 pixel high autoscroll zone at the bottom and top of the Launcher.
Also added new autoscrolling AP tests for testing autoscrolling at the top and bottom of the Launcher.
To post a comment you must log in.
Hi,
146 + def open_apps_ in_launcher( self): app_window( app)
147 + """Opens some apps in order to get icon stacking in the Launcher"""
148 + apps = [
149 + ("Calculator"),
150 + ("Mahjongg"),
151 + ("Text Editor"),
152 + ("Character Map"),
153 + ("Terminal"),
154 + ("Remmina")
155 + ]
156 + for app in apps:
157 + self.start_
I think this is better expressed as:
apps = ("Calculator", "Mahjongg", "Text Editor", "Character Map", "Terminal", "Remina") start_app_ window( app)
for app in apps:
self.
i.e.- don't need the parenthesis around each app name, and using a tuple is better than a list, since we don't need to modify the contents.
I'm also a bit worried that the unity code might break existing autopilot tests. We've kicked off an autopilot run here:
http:// 10.97.0. 6:8080/ view/autopilot/ job/autopilot- run-custom- branch/ 35/
So please don't merge this until those tests pass (or at least, don't show serious regressions compared to trunk).
Cheers,