Merge lp:~townsend/unity/fix-zeitgeist-build-failure into lp:unity

Proposed by Christopher Townsend
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 3627
Proposed branch: lp:~townsend/unity/fix-zeitgeist-build-failure
Merge into: lp:unity
Diff against target: 114 lines (+3/-58)
4 files modified
launcher/TrashLauncherIcon.cpp (+1/-1)
tests/test_application_launcher_icon.cpp (+1/-1)
unity-shared/DesktopApplicationManager.h (+1/-1)
unity-shared/ZeitgeistUtils.h (+0/-55)
To merge this branch: bzr merge lp:~townsend/unity/fix-zeitgeist-build-failure
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+201791@code.launchpad.net

Commit message

Removed the ZeitgeistUtils.h as this is no longer needed since Zeitgeist in main is now fixed.

Description of the change

Removed the ZeitgeistUtils.h as this is no longer needed since Zeitgeist in main is now fixed.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Cool, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/TrashLauncherIcon.cpp'
2--- launcher/TrashLauncherIcon.cpp 2013-10-18 18:48:25 +0000
3+++ launcher/TrashLauncherIcon.cpp 2014-01-15 14:53:40 +0000
4@@ -24,11 +24,11 @@
5 #include "config.h"
6 #include <glib/gi18n-lib.h>
7 #include <NuxCore/Logger.h>
8+#include <zeitgeist.h>
9
10 #include "QuicklistMenuItemLabel.h"
11 #include "unity-shared/DesktopApplicationManager.h"
12 #include "unity-shared/GnomeFileManager.h"
13-#include "unity-shared/ZeitgeistUtils.h"
14
15 namespace unity
16 {
17
18=== modified file 'tests/test_application_launcher_icon.cpp'
19--- tests/test_application_launcher_icon.cpp 2014-01-10 21:28:27 +0000
20+++ tests/test_application_launcher_icon.cpp 2014-01-15 14:53:40 +0000
21@@ -21,6 +21,7 @@
22
23 #include <config.h>
24 #include <gmock/gmock.h>
25+#include <zeitgeist.h>
26
27 #include <UnityCore/GLibWrapper.h>
28
29@@ -28,7 +29,6 @@
30 #include "FavoriteStore.h"
31 #include "UBusWrapper.h"
32 #include "UBusMessages.h"
33-#include "ZeitgeistUtils.h"
34 #include "mock-application.h"
35 #include "test_utils.h"
36 #include "test_standalone_wm.h"
37
38=== modified file 'unity-shared/DesktopApplicationManager.h'
39--- unity-shared/DesktopApplicationManager.h 2013-09-05 20:24:41 +0000
40+++ unity-shared/DesktopApplicationManager.h 2014-01-15 14:53:40 +0000
41@@ -20,11 +20,11 @@
42 #ifndef UNITYSHARED_DESKTOP_APPLICATION_MANAGER_H
43 #define UNITYSHARED_DESKTOP_APPLICATION_MANAGER_H
44
45+#include <zeitgeist.h>
46 #include <UnityCore/GLibWrapper.h>
47 #include <UnityCore/GLibSignal.h>
48
49 #include "unity-shared/ApplicationManager.h"
50-#include "unity-shared/ZeitgeistUtils.h"
51
52 namespace unity
53 {
54
55=== removed file 'unity-shared/ZeitgeistUtils.h'
56--- unity-shared/ZeitgeistUtils.h 2013-09-03 16:03:55 +0000
57+++ unity-shared/ZeitgeistUtils.h 1970-01-01 00:00:00 +0000
58@@ -1,55 +0,0 @@
59-// -*- Mode: C++; indent-tabs-mode: nil; tab-width: 2 -*-
60-/*
61- * Copyright (C) 2013 Canonical Ltd
62- *
63- * This program is free software: you can redistribute it and/or modify
64- * it under the terms of the GNU General Public License version 3 as
65- * published by the Free Software Foundation.
66- *
67- * This program is distributed in the hope that it will be useful,
68- * but WITHOUT ANY WARRANTY; without even the implied warranty of
69- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
70- * GNU General Public License for more details.
71- *
72- * You should have received a copy of the GNU General Public License
73- * along with this program. If not, see <http://www.gnu.org/licenses/>.
74- *
75- * Authored by: Marco Trevisan <marco.trevisan@canonical.com>
76- */
77-
78-#ifndef UNITY_ZEITGEIST_UTILS
79-#define UNITY_ZEITGEIST_UTILS
80-
81-#include <zeitgeist.h>
82-
83-/* Unfortunately valac-generated zeitgeist library contains invalid definitions
84- * that makes impossible for us to compile with -Werror -Wall, so we need to
85- * workaround them.
86- * Unfortunately using #pragma doesn't help much here as we can't limit the
87- * errors to the header inclusion only, so it's better to use this way in order
88- * to be able to include zeitgeist in multiple places without ignoring warnings.
89- */
90-
91-static ZeitgeistEvent* zeitgeist_event_constructv_full(GType object_type, const gchar* interpretation, const gchar* manifestation, const gchar* actor, const gchar* origin, va_list _vala_va_list)
92-{
93- return nullptr;
94-}
95-
96-namespace unity
97-{
98-namespace zeitgeist
99-{
100-namespace workaround
101-{
102-namespace
103-{
104-void ___dummy_function()
105-{
106- (void) zeitgeist_event_constructv_full;
107-}
108-} // anonymous namespace
109-} // workaround namespace
110-} // zeitgeist namespace
111-} // unity namespace
112-
113-#endif // UNITY_ZEITGEIST_UTILS
114\ No newline at end of file