Merge lp:~townsend/unity/fix-workspace-alt-tab into lp:unity
Status: | Merged |
---|---|
Approved by: | Christopher Townsend |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3470 |
Proposed branch: | lp:~townsend/unity/fix-workspace-alt-tab |
Merge into: | lp:unity |
Diff against target: |
43 lines (+22/-0) 2 files modified
launcher/SwitcherController.cpp (+4/-0) tests/autopilot/unity/tests/test_switcher.py (+18/-0) |
To merge this branch: | bzr merge lp:~townsend/unity/fix-workspace-alt-tab |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Unity Team | Pending | ||
Review via email: mp+179998@code.launchpad.net |
Commit message
Fix issue where the same app on different workspaces would not allow alt-tab to work properly when trying to switch to the last used app on the same workspace.
Description of the change
= Issue =
The same application opened on different workspaces will cause a problem when trying to alt-tab to the last used application on a particular workspace. See bug #1211261 on how to reproduce.
= Fix =
The SelectFirstItem() function the Switcher Controller code did not take into account that windows may not be in the same workspace. The fix adds logic to check if the ShowMode is Viewport only and if the window is not on the current desktop.
= Test =
Added an AP test to simulate the reproduction steps.
PASSED: Continuous integration, rev:3465 jenkins. qa.ubuntu. com/job/ unity-ci/ 302/ jenkins. qa.ubuntu. com/job/ unity-saucy- amd64-ci/ 191 jenkins. qa.ubuntu. com/job/ unity-saucy- armhf-ci/ 189 jenkins. qa.ubuntu. com/job/ unity-saucy- i386-ci/ 190
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity-ci/ 302/rebuild
http://