Merge lp:~townsend/unity/fix-tooltip-active-blur into lp:unity

Proposed by Christopher Townsend
Status: Merged
Approved by: Christopher Townsend
Approved revision: no longer in the source branch.
Merged at revision: 3497
Proposed branch: lp:~townsend/unity/fix-tooltip-active-blur
Merge into: lp:unity
Diff against target: 20 lines (+1/-2)
1 file modified
launcher/Tooltip.cpp (+1/-2)
To merge this branch: bzr merge lp:~townsend/unity/fix-tooltip-active-blur
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Marco Trevisan (Treviño) Approve
Brandon Schaefer (community) Approve
Review via email: mp+184653@code.launchpad.net

Commit message

Move the _compute_blur_bkg bool to the Tooltip::Draw() method since the CairoBaseWindow::Draw() method sets this to false causing subsequent draws to never update the background texture.

Description of the change

= Issue =
Tooltips do not have active blur which is visually inconsistent.

= Fix =
Move the _compute_blur_bkg bool to the Tooltip::Draw() method since the CairoBaseWindow::Draw() method sets this to false causing subsequent draws to never update the background texture.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ok

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/Tooltip.cpp'
2--- launcher/Tooltip.cpp 2012-12-14 12:14:34 +0000
3+++ launcher/Tooltip.cpp 2013-09-09 18:43:09 +0000
4@@ -110,8 +110,6 @@
5 int x = _anchorX - PADDING;
6 int y = anchor_tip_y - ANCHOR_HEIGHT / 2 - TOP_SIZE - CORNER_RADIUS - PADDING;
7
8- _compute_blur_bkg = true;
9-
10 SetBaseX(x);
11 SetBaseY(y);
12
13@@ -123,6 +121,7 @@
14
15 void Tooltip::Draw(nux::GraphicsEngine& gfxContext, bool forceDraw)
16 {
17+ _compute_blur_bkg = true;
18 CairoBaseWindow::Draw(gfxContext, forceDraw);
19 _tooltip_text->ProcessDraw(gfxContext, forceDraw);
20 }