Merge lp:~townsend/unity/fix-lp961890 into lp:unity
Proposed by
Christopher Townsend
Status: | Merged |
---|---|
Approved by: | Brandon Schaefer |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3618 |
Proposed branch: | lp:~townsend/unity/fix-lp961890 |
Merge into: | lp:unity |
Diff against target: |
56 lines (+28/-0) 2 files modified
plugins/unityshell/src/unityshell.cpp (+6/-0) tests/autopilot/unity/tests/test_showdesktop.py (+22/-0) |
To merge this branch: | bzr merge lp:~townsend/unity/fix-lp961890 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Brandon Schaefer (community) | Approve | ||
Review via email: mp+201034@code.launchpad.net |
Commit message
* If the Dash or Hud is opened when entering Show Desktop, ensure they are closed.
* Added some Autopilot tests for this condition.
Description of the change
= Issue =
If the Dash or Hud is open and Show Desktop is entered, the Dash or Hud remain open and the desktop is not really shown.
= Fix =
When entering Show Desktop, check to see if the Dash or Hud is open, and if so, close it. Note that Design said to "minimize" the Dash or Hud, but there is no minimizing of these. They are either opened or closed. Also, when leaving Show Desktop, the Dash or Hud will not be reopened.
= Test =
Added 2 AP tests to test for this condition.
To post a comment you must log in.
FAILED: Continuous integration, rev:3617 jenkins. qa.ubuntu. com/job/ unity-ci/ 543/ jenkins. qa.ubuntu. com/job/ unity-trusty- amd64-ci/ 79 jenkins. qa.ubuntu. com/job/ unity-trusty- armhf-ci/ 75 jenkins. qa.ubuntu. com/job/ unity-trusty- i386-ci/ 77/console
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity- ci/543/ rebuild
http://