Merge lp:~townsend/unity/fix-lp1309739 into lp:unity

[Christopher Townsend]

Fix issue where scaling the edge illumination up and down with the size of the Launcher icons would cause the illumination border to be offset and smaller than the icon.

When setting the Launcher icons smaller and larger than the default, specifically less than 40 and greater than 58, the icon edge illumination would be offset and sometimes smaller than the icon.

It appears Gdk is unable to scale the icon glow .svg properly which causes the glow to be offset and smaller. This fix is use the old .png instead which just stretches or shrinks. I also kept around the old .svg but renamed it so Unity can't find it.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3792
http://jenkins.qa.ubuntu.com/job/unity-ci/915/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/915/rebuild

review: Approve (continuous-integration)

[Brandon Schaefer (brandontschaefer)]

Nice, LGTM

review: Approve

[Marco Trevisan (Treviño) (3v1n0)]

Well, while this is a way to fix the issue, the problem - according to the tests I did some weeks ago - is not caused by math errors, but to the fact that for some reasons the SVGs we use aren't properly resized (it seems to be caused by the glow used there), so I'm not sure what's the best approach here.

In fact, using the old .png again fixes the issue, but it doesn't give us the visual quality benefits when scaling up the UI (same as the fix proposed here)... So maybe a compromise would be to just get rid of the smallest .svg icon (resources/launcher_icon_glow_62.svg), and going back with the png. Without logic changes.

review: Needs Information

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3793
http://jenkins.qa.ubuntu.com/job/unity-ci/922/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-armhf-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/922/rebuild

review: Approve (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

+1

review: Approve

=== added file 'resources/launcher_icon_glow_62.png'
Binary files resources/launcher_icon_glow_62.png	1970-01-01 00:00:00 +0000 and resources/launcher_icon_glow_62.png	2014-05-08 18:53:54 +0000 differ
=== renamed file 'resources/launcher_icon_glow_62.svg' => 'resources/launcher_icon_glow_62.svg.save'