Merge lp:~townsend/unity/fix-lp1291362 into lp:unity

Proposed by Christopher Townsend
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3790
Proposed branch: lp:~townsend/unity/fix-lp1291362
Merge into: lp:unity
Diff against target: 16 lines (+2/-2)
1 file modified
launcher/ApplicationLauncherIcon.cpp (+2/-2)
To merge this branch: bzr merge lp:~townsend/unity/fix-lp1291362
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+216597@code.launchpad.net

Commit message

When setting the STARTING quirk for Application Launcher icons, only do it for the monitor specified in the passed in args.

Description of the change

When setting the STARTING quirk for Application Launcher icons, only do it for the monitor specified in the passed in args.

To test:
* Have a multi-monitor setup.
* Do not have the Launcher on the left most monitor.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/ApplicationLauncherIcon.cpp'
2--- launcher/ApplicationLauncherIcon.cpp 2014-04-02 14:36:55 +0000
3+++ launcher/ApplicationLauncherIcon.cpp 2014-04-21 15:10:36 +0000
4@@ -383,10 +383,10 @@
5
6 if (!IsRunning() || (IsRunning() && !user_visible)) // #1 above
7 {
8- if (GetQuirk(Quirk::STARTING))
9+ if (GetQuirk(Quirk::STARTING, arg.monitor))
10 return;
11
12- SetQuirk(Quirk::STARTING, true);
13+ SetQuirk(Quirk::STARTING, true, arg.monitor);
14 OpenInstanceLauncherIcon(arg.timestamp);
15 }
16 else // app is running