lp:~townsend/unity/fix-lp1251777

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:unity

Christopher Townsend: Disapprove on 2013-12-04

Brandon Schaefer (community): Needs Fixing on 2013-11-21

PS Jenkins bot (community): Approve (continuous-integration) on 2013-11-20

Diff: 37 lines (+12/-0)

2 files modified

tests/autopilot/unity/tests/test_wm_keybindings.py (+8/-0)
unity-shared/PluginAdapter.cpp (+4/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1251777: [regression] Semi-maximizing and then restoring the window does not return it to it's original place using Ctrl-Super-Left/Right

Medium

Fix Released

Link a bug report

Related blueprints

3598. By Christopher Townsend on 2013-11-20

Fixes issue when using the Ctrl-Super-Left/Right shortcuts to vertically semi-maximize a window and then restoring the window would not place the wi
ndow back in its original place.

3597. By Eleni Maria Stea on 2013-11-18

adds virtual destructors to classes with virtual methods to prevent memory leaks - ABI break.

Approved by Christopher Townsend, PS Jenkins bot.

3596. By Marco Trevisan (Treviño) on 2013-11-17

Unity: always prefer passing [this] to lambdas than [&].

Approved by PS Jenkins bot, Andrea Azzarone.

3595. By Andrea Azzarone on 2013-11-17

Alt-Tab, shutdown dialog and shortcut overlay should not be transparent in Low GFX Mode. Fixes: https://bugs.launchpad.net/bugs/1170508.

Approved by PS Jenkins bot, Marco Trevisan (Treviño), Christopher Townsend.

3594. By Christopher Townsend on 2013-11-17

In low graphics mode, only draw the Launcher background as needed instead of all of the time, even if the Launcher is hidden. Fixes: https://bugs.launchpad.net/bugs/1179210.

Approved by Marco Trevisan (Treviño), PS Jenkins bot.

3593. By Marco Trevisan (Treviño) on 2013-11-17

UnityScreen: remove the useless and expensive gl{Push,Pop}Attrib calls

For some reasons this code was copied by the opengl plugin as a workaround
to fix the state of our screen after that nux has drawn.
Actually this is not needed, the only thing we really need to do is to fix the
current Viewport, because nux seems to leave it in a bad state which would
lead to flickering menus, fullscreen windows, tooltip and missing windows
thumbnails in switcher.

Thanks to Sam Spilsbury for his precious support. Fixes: https://bugs.launchpad.net/bugs/1251275.

Approved by PS Jenkins bot, Eleni Maria Stea, Andrea Azzarone.

3592. By Marco Trevisan (Treviño) on 2013-11-08

Convert compiz regions / rects to nux::Geometry's and back easily.

Approved by PS Jenkins bot, Christopher Townsend.

3591. By Sam Spilsbury on 2013-11-07

Don't re-present all of our windows on every frame. Only do that if damage intersects it.

Use the new APIs exposed by compiz and nux to intelligently determine which windows need to be presented per-frame and only register damage for those windows. This fixes two things:

1. BaseWindows being redrawn from scratch every time damage was registered over them. That was incorrect and should only be done in the case of background blurs.
2. BaseWindows being drawn to the screen on every frame, regardless of whether or not they needed to be. Now they will only be drawn if some damage intersects beneath them. Note that unity will expand the damage region to accomadate the base window since nux does not support geometry clipping. So if there is a partial intersection of the launcher for example, the area of the screen which contains the launcher will be re-painted (but the launcher itself won't be redrawn, just its texture)

(LP: #1080947). Fixes: https://bugs.launchpad.net/bugs/1080947.

Approved by PS Jenkins bot, Stephen M. Webb, Christopher Townsend, Brandon Schaefer.

3590. By Eleni Maria Stea on 2013-11-07

the branch fixes the following compile errors:
  1. SetReferenceFramebuffer function gets 3 parameters (Nux/WindowCompositor.h)
  2. RenderInterfaceFromForeignCmd gets const reference not pointer as argument
  (Nux/WindowThread.h).

Approved by PS Jenkins bot, Andrea Azzarone.

3589. By PS Jenkins bot on 2013-11-07

Releasing 7.1.2+14.04.20131106.1-0ubuntu1 (revision 3588 from lp:unity).

Approved by PS Jenkins bot.