Merge lp:~townsend/unity/fix-lp1246891-trusty into lp:unity/7.2

Proposed by Christopher Townsend
Status: Merged
Approved by: Stephen M. Webb
Approved revision: no longer in the source branch.
Merged at revision: 3824
Proposed branch: lp:~townsend/unity/fix-lp1246891-trusty
Merge into: lp:unity/7.2
Diff against target: 25 lines (+9/-5)
1 file modified
launcher/Launcher.cpp (+9/-5)
To merge this branch: bzr merge lp:~townsend/unity/fix-lp1246891-trusty
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Stephen M. Webb (community) Approve
Review via email: mp+259286@code.launchpad.net

Commit message

When we quit the quicklist it would check if the mouse was over the launcher, if it wasn't it would fold the launcher. We don't need to check this if we are in keynav as we want all the icons to be unfolded.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Stephen M. Webb (bregma) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/Launcher.cpp'
2--- launcher/Launcher.cpp 2014-12-15 19:06:58 +0000
3+++ launcher/Launcher.cpp 2015-05-15 19:52:34 +0000
4@@ -2308,13 +2308,17 @@
5
6 void Launcher::RecvQuicklistClosed(nux::ObjectPtr<QuicklistView> const& quicklist)
7 {
8- nux::Point pt = nux::GetWindowCompositor().GetMousePosition();
9- if (!GetAbsoluteGeometry().IsInside(pt))
10+ if (!IsInKeyNavMode())
11 {
12- // The Quicklist just closed and the mouse is outside the launcher.
13- SetHover(false);
14- SetStateMouseOverLauncher(false);
15+ nux::Point pt = nux::GetWindowCompositor().GetMousePosition();
16+ if (!GetAbsoluteGeometry().IsInside(pt))
17+ {
18+ // The Quicklist just closed and the mouse is outside the launcher.
19+ SetHover(false);
20+ SetStateMouseOverLauncher(false);
21+ }
22 }
23+
24 // Cancel any prior state that was set before the Quicklist appeared.
25 SetActionState(ACTION_NONE);
26

Subscribers

People subscribed via source and target branches

to status/vote changes: