Merge lp:~townsend/unity/fix-lp1179210 into lp:unity

[Christopher Townsend]

In low graphics mode, only draw the Launcher background as needed instead of all of the time, even if the Launcher is hidden.

= Issue =
When using low graphics and the Launcher is hidden, the background color of the Launcher is always drawn on the screen causing an ugly artefact.

= Fix =
Instead of always drawing the background, only draw the background as needed in the same manner as the normal graphic mode does it.

= Test =
Restart Unity in low graphics mode by doing this: UNITY_LOW_GFX_MODE=1 setsid unity

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3592
http://jenkins.qa.ubuntu.com/job/unity-ci/498/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/29
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/29
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/29

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-ci/498/rebuild

review: Approve (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

right, thanks!

review: Approve

=== modified file 'launcher/Launcher.cpp'
--- launcher/Launcher.cpp	2013-10-29 22:39:42 +0000
+++ launcher/Launcher.cpp	2013-11-07 20:35:55 +0000
@@ -1639,12 +1639,6 @@
 
   nux::Color clear_colour = nux::Color(0x00000000);
 
-  if (Settings::Instance().GetLowGfxMode())
-  {
-    clear_colour = options()->background_color;
-    clear_colour.alpha = 1.0f;
-  }
-
   // clear region
   GfxContext.PushClippingRectangle(base);
   gPainter.PushDrawColorLayer(GfxContext, base, clear_colour, true, ROP);
@@ -1777,6 +1771,12 @@
       gPainter.Paint2DQuadColor(GfxContext, bkg_box, color);
     }
   }
+  else
+  {
+    nux::Color color = options()->background_color;
+    color.alpha = 1.0f;
+    gPainter.Paint2DQuadColor(GfxContext, bkg_box, color);
+  }
 
   GfxContext.GetRenderStates().SetPremultipliedBlend(nux::SRC_OVER);