Merge lp:~townsend/unity/fix-keynav-scroll into lp:unity
Status: | Merged |
---|---|
Approved by: | Stephen M. Webb |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3490 |
Proposed branch: | lp:~townsend/unity/fix-keynav-scroll |
Merge into: | lp:unity |
Diff against target: |
12 lines (+1/-1) 1 file modified
launcher/Launcher.cpp (+1/-1) |
To merge this branch: | bzr merge lp:~townsend/unity/fix-keynav-scroll |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Stephen M. Webb (community) | Approve | ||
Review via email:
|
Commit message
Fixes issue where entering keynav mode may make the BFB icon scroll off the top of the Launcher.
Description of the change
= Issue =
If there are many icons in the Launcher leading to the concertina effect and entering keynav mode, a condition may occur where the BFB icon may scroll off the top of the Launcher (see bug #1068166). This issue has recently led to AP test failures and actually causing the AP test run to get stuck (see bug #1219636).
= Fix =
When setting the hover, do not set the _enter_y variable if in KeyNav Mode. This variable is used to determine if the Launcher should scroll when hover is set.
= Test =
Running autopilot run --verbose unity.tests.
Funny how one little change can have such big results.