Merge lp:~townsend/unity-scope-home/fix-search-hint-localization into lp:unity-scope-home

Proposed by Christopher Townsend on 2013-04-01
Status: Merged
Approved by: Paweł Stołowski on 2013-04-15
Approved revision: 83
Merged at revision: 86
Proposed branch: lp:~townsend/unity-scope-home/fix-search-hint-localization
Merge into: lp:unity-scope-home
Diff against target: 12 lines (+1/-1)
1 file modified
src/master-scopes.vala (+1/-1)
To merge this branch: bzr merge lp:~townsend/unity-scope-home/fix-search-hint-localization
Reviewer Review Type Date Requested Status
Paweł Stołowski 2013-04-01 Approve on 2013-04-15
PS Jenkins bot (community) continuous-integration Approve on 2013-04-01
Review via email: mp+156423@code.launchpad.net

Commit message

Fix localization of the search hint.

Description of the change

The initial search hint in the Dash Search bar is not translated. This MP fixes the search hint after the scopes load. A fix is also needed in libunity-7.0 and also a unity-scope-home gettext domain is needed for the various different languages.

I tested this by first creating a unity-scope-home.mo file by coalescing the unity-lens-*.mo files by first running msgunfmt on those .mo files and converting them to .po files and then taking all of those and creating one big unity-scope-home.po file and then running msgfmt on that. I did this in Spanish since I can marginally read Spanish:)

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Paweł Stołowski (stolowski) wrote :

Looks good. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/master-scopes.vala'
2--- src/master-scopes.vala 2013-03-21 17:07:48 +0000
3+++ src/master-scopes.vala 2013-04-01 21:04:23 +0000
4@@ -278,7 +278,7 @@
5 if (master_def != null)
6 {
7 var scope = new Unity.MasterScope (info.dbus_path, info.id);
8- scope.search_hint = info.search_hint;
9+ scope.search_hint = _(info.search_hint);
10 var category_set = new Unity.CategorySet ();
11
12 Icon? main_icon = null;

Subscribers

People subscribed via source and target branches