Merge lp:~townsend/libertine/release-hotfixes into lp:libertine/trunk

Proposed by Christopher Townsend
Status: Merged
Approved by: Larry Price
Approved revision: 143
Merged at revision: 143
Proposed branch: lp:~townsend/libertine/release-hotfixes
Merge into: lp:libertine/trunk
Diff against target: 63 lines (+24/-3)
3 files modified
debian/changelog (+10/-0)
python/libertine/ChrootContainer.py (+5/-0)
tools/completions/libertine-container-manager (+9/-3)
To merge this branch: bzr merge lp:~townsend/libertine/release-hotfixes
Reviewer Review Type Date Requested Status
Larry Price Approve
Review via email: mp+300918@code.launchpad.net

Commit message

Hotfixes for the 1.3 release:
- Install software-properties-common in vivid chroot containers before adding stable overlay.
- Update bash completions for new configure syntax.

To post a comment you must log in.
Revision history for this message
Larry Price (larryprice) wrote :

+1

review: Approve
144. By Christopher Townsend

Add own debian/changelog entries.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2016-07-21 17:26:54 +0000
3+++ debian/changelog 2016-07-22 16:44:05 +0000
4@@ -1,3 +1,13 @@
5+libertine (1.3-0ubuntu1) UNRELEASED; urgency=medium
6+
7+ [ Larry Price ]
8+ * Hotfixes for the 1.3 release:
9+ - Install software-properties-common in vivid chroot containers before
10+ adding stable overlay.
11+ - Update bash completions for new configure syntax.
12+
13+ -- Chris Townsend <christopher.townsend@canonical.com> Fri, 22 Jul 2016 12:41:58 -0400
14+
15 libertine (1.3+16.10.20160721.2-0ubuntu1) yakkety; urgency=medium
16
17 [ Brandon Schaefer ]
18
19=== modified file 'python/libertine/ChrootContainer.py'
20--- python/libertine/ChrootContainer.py 2016-07-01 16:48:11 +0000
21+++ python/libertine/ChrootContainer.py 2016-07-22 16:44:05 +0000
22@@ -127,6 +127,11 @@
23 if self.installed_release == "vivid":
24 if verbosity == 1:
25 print("Installing the Vivid Stable Overlay PPA...")
26+ if not self.install_package("software-properties-common", verbosity):
27+ print("Failure installing software-properties-common during container creation")
28+ self.destroy_libertine_container()
29+ return False
30+
31 self.run_in_container("add-apt-repository ppa:ci-train-ppa-service/stable-phone-overlay -y")
32 self.update_packages(verbosity)
33
34
35=== modified file 'tools/completions/libertine-container-manager'
36--- tools/completions/libertine-container-manager 2016-06-07 19:49:27 +0000
37+++ tools/completions/libertine-container-manager 2016-07-22 16:44:05 +0000
38@@ -48,7 +48,7 @@
39 opts="--help"
40 ;;
41 "configure" )
42- opts="--help --id --multiarch --add-archive --delete-archive"
43+ opts="--help --id --multiarch --archive"
44 ;;
45 "set-default" )
46 opts="--help --id --clear"
47@@ -59,8 +59,14 @@
48 esac
49 fi
50
51- if [[ ${cmd} == "configure" && "${COMP_WORDS[COMP_CWORD-1]}" == "--multiarch" ]]; then
52- opts="enable disable"
53+ if [[ ${cmd} == "configure" ]]; then
54+ if [[ "${COMP_WORDS[COMP_CWORD-1]}" == "--multiarch" ]]; then
55+ opts="enable disable"
56+ elif [[ "${COMP_WORDS[COMP_CWORD-1]}" == "--archive" ]]; then
57+ opts="add remove"
58+ elif [[ " ${COMP_WORDS[@]} " =~ " --archive " ]]; then
59+ opts="--archive-name --public-key-file"
60+ fi
61 fi
62
63 if [[ -z ${opts} && "${COMP_CWORD}" == "1" ]]; then

Subscribers

People subscribed via source and target branches