Merge lp:~townsend/libertine/fix-chroot-start into lp:libertine

Proposed by Christopher Townsend
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 398
Merged at revision: 398
Proposed branch: lp:~townsend/libertine/fix-chroot-start
Merge into: lp:libertine
Diff against target: 12 lines (+1/-1)
1 file modified
python/libertine/Libertine.py (+1/-1)
To merge this branch: bzr merge lp:~townsend/libertine/fix-chroot-start
Reviewer Review Type Date Requested Status
Stephen M. Webb (community) Approve
Libertine CI Bot continuous-integration Approve
Review via email: mp+316862@code.launchpad.net

Commit message

Return True instead of pass for start_container() in the base class. Fixes running operation in chroot's.

To post a comment you must log in.
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

PASSED: Continuous integration, rev:398
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/378/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/libertine/job/build/723
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=default/593
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=zesty,testname=default/593
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=xenial+overlay,testname=default/593
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=zesty,testname=default/593
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-0-fetch/733
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/714
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/714/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/714
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/714/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/714
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/714/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/714
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/714/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/378/rebuild

review: Approve (continuous-integration)
Revision history for this message
Stephen M. Webb (bregma) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'python/libertine/Libertine.py'
2--- python/libertine/Libertine.py 2017-02-07 16:32:02 +0000
3+++ python/libertine/Libertine.py 2017-02-09 15:42:54 +0000
4@@ -170,7 +170,7 @@
5 'running' state, the meaning of which depends on the type of the
6 container.
7 """
8- pass
9+ return True
10
11 def stop_container(self):
12 """

Subscribers

People subscribed via source and target branches