Libertine

Merge lp:~townsend/libertine/disable-seccomp into lp:libertine

  1. disable-seccomp
  2. Merge into devel
Proposed by Christopher Townsend
Status: Merged
Approved by: Christopher Townsend
Approved revision: 157
Merged at revision: 156
Proposed branch: lp:~townsend/libertine/disable-seccomp
Merge into: lp:libertine
Diff against target: 13 lines (+3/-0)
1 file modified
python/libertine/ChrootContainer.py (+3/-0)
To merge this branch: bzr merge lp:~townsend/libertine/disable-seccomp
Reviewer Review Type Date Requested Status
Libertine CI Bot continuous-integration Approve
Stephen M. Webb (community) Approve
Review via email: mp+282597@code.launchpad.net

Commit message

Disable seccomp when running proot. Fixes incompatible kernels.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

For the record: this should be a temporary measure until we find out why it's necessary.

review: Approve
lp:~townsend/libertine/disable-seccomp updated
157. By Christopher Townsend

Added a FIXME line to keep track of the temporary measure.

Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

PASSED: Continuous integration, rev:156
https://jenkins.canonical.com/libertine/job/libertine-ci-verify-mp/85/
Executed test runs:
    None: https://jenkins.canonical.com/libertine/job/libertine-ci-update-mp/982/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/libertine-ci-verify-mp/85/rebuild

review: Approve (continuous-integration)
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

PASSED: Continuous integration, rev:157
https://jenkins.canonical.com/libertine/job/libertine-ci-verify-mp/86/
Executed test runs:
    None: https://jenkins.canonical.com/libertine/job/libertine-ci-update-mp/983/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/libertine-ci-verify-mp/86/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'python/libertine/ChrootContainer.py'
2--- python/libertine/ChrootContainer.py 2015-12-22 17:28:10 +0000
3+++ python/libertine/ChrootContainer.py 2016-01-14 14:47:20 +0000
4@@ -194,6 +194,9 @@
5 return proot_cmd
6
7 def launch_application(self, app_exec_line):
8+ # FIXME: Disabling seccomp is a temporary measure until we fully understand why we need
9+ # it or figure out when we need it.
10+ os.environ['PROOT_NO_SECCOMP'] = '1'
11 proot_cmd = self._build_proot_command()
12
13 args = shlex.split(proot_cmd)

Subscribers

People subscribed via source and target branches