Merge lp:~townsend/libertine-scope/release-1.2 into lp:libertine-scope/release

Proposed by Christopher Townsend
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 37
Merged at revision: 37
Proposed branch: lp:~townsend/libertine-scope/release-1.2
Merge into: lp:libertine-scope/release
Diff against target: 236 lines (+70/-35)
9 files modified
CMakeLists.txt (+4/-2)
data/CMakeLists.txt (+4/-14)
data/icon.svg (+21/-0)
data/libertine-scope.ini.in (+3/-7)
debian/changelog (+18/-0)
libertine-scope.apparmor (+10/-2)
libertine-scope/CMakeLists.txt (+1/-1)
manifest.json.in (+6/-6)
po/libertine-scope.pot (+3/-3)
To merge this branch: bzr merge lp:~townsend/libertine-scope/release-1.2
Reviewer Review Type Date Requested Status
Stephen M. Webb (community) Approve
Review via email: mp+296255@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

All good.

review: Approve
Revision history for this message
Christopher Townsend (townsend) wrote :

Removed commit message per robru's email.

38. By Stephen M. Webb

changed the icons and logos once again

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2016-05-05 15:35:18 +0000
3+++ CMakeLists.txt 2016-06-02 17:14:16 +0000
4@@ -1,6 +1,6 @@
5 cmake_minimum_required(VERSION 3.0)
6 project(libertine-scope
7- VERSION 1.1
8+ VERSION 1.2
9 LANGUAGES CXX)
10
11 # We require at least g++ 4.9, to avoid ABI breakage with earlier versions.
12@@ -42,11 +42,13 @@
13 ${LIBERTINE_INCLUDE_DIRS}
14 )
15
16+set(PACKAGE_NAME "libertine-scope.ubuntu")
17+set(APP ${PROJECT})
18+
19 # Important project paths
20 set(SCOPE_INSTALL_DIR ${CMAKE_INSTALL_FULL_LIBDIR}/unity-scopes/libertine-scope/)
21 set(SCOPE_NAME "libertine-scope")
22 set(GETTEXT_PACKAGE "${SCOPE_NAME}")
23-set(PACKAGE_NAME "libertine-scope.canonical")
24
25 # If we need to refer to the scope's name or package in code, these definitions will help
26 add_definitions(-DPACKAGE_NAME="${PACKAGE_NAME}")
27
28=== modified file 'data/CMakeLists.txt'
29--- data/CMakeLists.txt 2016-01-07 19:35:25 +0000
30+++ data/CMakeLists.txt 2016-06-02 17:14:16 +0000
31@@ -3,13 +3,13 @@
32 # .so file so that the test tools can find them.
33 intltool_merge_translations(
34 "libertine-scope.ini.in"
35- "${CMAKE_CURRENT_BINARY_DIR}/${SCOPE_NAME}.ini"
36+ "${CMAKE_CURRENT_BINARY_DIR}/${PACKAGE_NAME}_${SCOPE_NAME}.ini"
37 ALL
38 UTF8
39 )
40 intltool_merge_translations(
41 "libertine-scope-settings.ini.in"
42- "${CMAKE_CURRENT_BINARY_DIR}/${SCOPE_NAME}-settings.ini"
43+ "${CMAKE_CURRENT_BINARY_DIR}/${PACKAGE_NAME}_${SCOPE_NAME}-settings.ini"
44 ALL
45 UTF8
46 )
47@@ -17,26 +17,16 @@
48 # Install the scope ini files
49 install(
50 FILES
51- "${CMAKE_CURRENT_BINARY_DIR}/${SCOPE_NAME}.ini"
52- "${CMAKE_CURRENT_BINARY_DIR}/${SCOPE_NAME}-settings.ini"
53+ "${CMAKE_CURRENT_BINARY_DIR}/${PACKAGE_NAME}_${SCOPE_NAME}.ini"
54+ "${CMAKE_CURRENT_BINARY_DIR}/${PACKAGE_NAME}_${SCOPE_NAME}-settings.ini"
55 DESTINATION
56 ${SCOPE_INSTALL_DIR}
57 )
58
59-# Put the logo file in the build directory next to the scope
60-# .ini file so that the test tools can find it.
61-configure_file(
62- "logo.png"
63- "${CMAKE_CURRENT_BINARY_DIR}/logo.png"
64- @ONLY
65- COPYONLY
66-)
67-
68 # Install the scope images
69 install(
70 FILES
71 "icon.png"
72- "logo.png"
73 DESTINATION
74 ${SCOPE_INSTALL_DIR}
75 )
76
77=== modified file 'data/icon.png'
78Binary files data/icon.png 2015-12-29 21:50:58 +0000 and data/icon.png 2016-06-02 17:14:16 +0000 differ
79=== added file 'data/icon.svg'
80--- data/icon.svg 1970-01-01 00:00:00 +0000
81+++ data/icon.svg 2016-06-02 17:14:16 +0000
82@@ -0,0 +1,21 @@
83+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
84+<!-- Created with Inkscape (http://www.inkscape.org/) -->
85+
86+<svg
87+ xmlns:svg="http://www.w3.org/2000/svg"
88+ xmlns="http://www.w3.org/2000/svg"
89+ version="1.1"
90+ width="275"
91+ height="275"
92+ id="svg2">
93+ <defs
94+ id="defs4" />
95+ <g
96+ transform="translate(-295.17857,-338.61217)"
97+ id="layer1">
98+ <path
99+ d="m 296.78571,612.63003 c 0,0 104.06285,-132.7859 104.06285,-132.7859 0,0 -104.06285,-140.24982 -104.06285,-140.24982 l 67.30299,0 c 0,0 83.34749,113.48826 83.34749,113.48826 l -126.86477,159.54746 -23.78571,0 z M 417.28794,500.06578 544.11662,339.59431 c 0,0 24.45481,0 24.45481,0 L 464.47749,471.26578 c 0,0 104.09394,141.36425 104.09394,141.36425 l -67.30357,0 c 0,0 -83.97992,-112.56425 -83.97992,-112.56425 z"
100+ id="path2830"
101+ style="fill:#000000" />
102+ </g>
103+</svg>
104
105=== modified file 'data/libertine-scope.ini.in'
106--- data/libertine-scope.ini.in 2015-12-29 21:50:58 +0000
107+++ data/libertine-scope.ini.in 2016-06-02 17:14:16 +0000
108@@ -1,11 +1,7 @@
109 [ScopeConfig]
110-_DisplayName=Legacy Applications Scope
111-_Description=Deb-packaged X11-based legacy applications.
112+_DisplayName=XApps
113+_Description=Surface and launch DEB-packaged X11-based applications.
114 Art=screenshot.png
115-Author=Stephen M. Webb
116+Author=The Canonical Libertine Team <libertine-team@lists.launchpad.net>
117 Icon=icon.png
118 Keywords=apps
119-
120-[Appearance]
121-PageHeader.Logo=logo.png
122-
123
124=== removed file 'data/logo.png'
125Binary files data/logo.png 2016-01-06 17:19:35 +0000 and data/logo.png 1970-01-01 00:00:00 +0000 differ
126=== removed file 'data/logo.xcf'
127Binary files data/logo.xcf 2016-01-06 17:19:35 +0000 and data/logo.xcf 1970-01-01 00:00:00 +0000 differ
128=== added file 'data/project-logo.xcf'
129Binary files data/project-logo.xcf 1970-01-01 00:00:00 +0000 and data/project-logo.xcf 2016-06-02 17:14:16 +0000 differ
130=== modified file 'debian/changelog'
131--- debian/changelog 2016-05-06 16:16:35 +0000
132+++ debian/changelog 2016-06-02 17:14:16 +0000
133@@ -1,3 +1,21 @@
134+libertine-scope (1.2-0ubuntu1) UNRELEASED; urgency=medium
135+
136+ [ Chris Townsend ]
137+ * Using the "unconfined" template is strongly discouraged, so use the
138+ "ubuntu-scope-network" template and define read_path and write_path.
139+ * Use the ubuntu package namespace as canonical is used for special 3rd
140+ party click packages. Also use variable substitution in the manifest.json.in
141+ file to match what's in the CMakefile.
142+
143+ [ Kyle Nitzsche ]
144+ * Install ini file names and .so file to be fully qualified.
145+
146+ [ Stephen M. Webb ]
147+ * Use new icon and logo for the Libertine Scope. Also renam "Legacy
148+ Applications Scope" to "XApps".
149+
150+ -- Chris Townsend <christopher.townsend@canonical.com> Wed, 01 Jun 2016 16:22:18 -0400
151+
152 libertine-scope (1.1+16.04.20160506-0ubuntu1) xenial; urgency=medium
153
154 [ Chris Townsend ]
155
156=== modified file 'libertine-scope.apparmor'
157--- libertine-scope.apparmor 2016-03-18 13:02:44 +0000
158+++ libertine-scope.apparmor 2016-06-02 17:14:16 +0000
159@@ -1,6 +1,14 @@
160 {
161- "template": "unconfined",
162+ "template": "ubuntu-scope-network",
163 "policy_groups": [],
164- "policy_version": 1.3
165+ "policy_version": 1.3,
166+ "read_path": [
167+ "@{HOME}/.local/share/libertine/",
168+ "@{HOME}/.cache/libertine-container/",
169+ "@{CLICK_DIR}/com.ubuntu.puritine/"
170+ ],
171+ "write_path": [
172+ "/{dev,run}/shm/lttng-ust-wait-5*"
173+ ]
174 }
175
176
177=== modified file 'libertine-scope/CMakeLists.txt'
178--- libertine-scope/CMakeLists.txt 2016-04-27 16:33:00 +0000
179+++ libertine-scope/CMakeLists.txt 2016-06-02 17:14:16 +0000
180@@ -27,7 +27,7 @@
181
182 set_target_properties(scope
183 PROPERTIES
184- OUTPUT_NAME "${SCOPE_NAME}"
185+ OUTPUT_NAME "${PACKAGE_NAME}_${SCOPE_NAME}"
186 )
187
188 install(TARGETS scope
189
190=== modified file 'manifest.json.in'
191--- manifest.json.in 2015-12-29 21:50:58 +0000
192+++ manifest.json.in 2016-06-02 17:14:16 +0000
193@@ -4,12 +4,12 @@
194 "framework": "ubuntu-sdk-15.04.3",
195 "hooks": {
196 "libertine-scope": {
197- "apparmor": "libertine-scope.apparmor",
198- "scope": "libertine-scope"
199+ "apparmor": "@SCOPE_NAME@.apparmor",
200+ "scope": "@SCOPE_NAME@"
201 }
202 },
203- "maintainer": "Stephen M. Webb <stephen.webb@canonical.com>",
204- "name": "libertine-scope.canonical",
205- "title": "libertine-scope",
206- "version": "0.1"
207+ "maintainer": "Ubuntu Libertine Team <libertine-team@lists.launchpad.net>",
208+ "name": "@PACKAGE_NAME@",
209+ "title": "@SCOPE_NAME@",
210+ "version": "@PROJECT_VERSION@"
211 }
212
213=== modified file 'po/libertine-scope.pot'
214--- po/libertine-scope.pot 2016-04-27 18:37:46 +0000
215+++ po/libertine-scope.pot 2016-06-02 17:14:16 +0000
216@@ -8,7 +8,7 @@
217 msgstr ""
218 "Project-Id-Version: PACKAGE VERSION\n"
219 "Report-Msgid-Bugs-To: \n"
220-"POT-Creation-Date: 2016-04-27 14:37-0400\n"
221+"POT-Creation-Date: 2016-06-02 13:05-0400\n"
222 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
223 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
224 "Language-Team: LANGUAGE <LL@li.org>\n"
225@@ -18,9 +18,9 @@
226 "Content-Transfer-Encoding: 8bit\n"
227
228 #: ../data/libertine-scope.ini.in.h:1
229-msgid "Legacy Applications Scope"
230+msgid "XApps"
231 msgstr ""
232
233 #: ../data/libertine-scope.ini.in.h:2
234-msgid "Deb-packaged X11-based legacy applications."
235+msgid "Surface and launch DEB-packaged X11-based applications."
236 msgstr ""

Subscribers

People subscribed via source and target branches