Merge lp:~townsend/duplicity/fix-1161599 into lp:duplicity/0.6
Proposed by
Christopher Townsend
Status: | Merged |
---|---|
Merged at revision: | 912 |
Proposed branch: | lp:~townsend/duplicity/fix-1161599 |
Merge into: | lp:duplicity/0.6 |
Diff against target: |
34 lines (+6/-1) 1 file modified
duplicity/backends/u1backend.py (+6/-1) |
To merge this branch: | bzr merge lp:~townsend/duplicity/fix-1161599 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
edso | Approve | ||
Review via email: mp+159849@code.launchpad.net |
Description of the change
Transient socket or HTTP errors will cause a retry of the PUT for a backup. This would then lead to 400 Bad Request errors from the server. This MP:
* Fixes the case where the file pointer to the backup file was not being set back to the beginning of the file when an error occurs. This causes subsequent retries to fail with 400 Bad Request errors from the server. This is due to a change in revno. 901 where a file handle is used instead of a bytearray.
* Fixes the removal of Content-Length from the header in revno. 901. Content-Length is required according to the Ubuntu One API documentation.
To post a comment you must log in.
looks good to me. like that you kept the memory saving file pointer.
thanks ede/duply.net