lp:~townsend/compiz/fix-minimize-unredirect-window

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.10 at revision 3686

PS Jenkins bot (community): Approve (continuous-integration) on 2013-05-08

Sam Spilsbury: Approve on 2013-05-08

Christopher Townsend (community): Needs Resubmitting on 2013-05-07

Diff: 72 lines (+27/-2)

4 files modified

plugins/opengl/src/fsregion/fsregion.cpp (+1/-1)
plugins/opengl/src/fsregion/fsregion.h (+2/-1)
plugins/opengl/src/fsregion/tests/test-fsregion.cpp (+19/-0)
plugins/opengl/src/paint.cpp (+5/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1053895: Screen sometimes does not redraw upon exiting fullscreen when "Unredirect Fullscreen Windows" is enabled

Medium

Fix Released

Link a bug report

Related blueprints

3688. By Christopher Townsend on 2013-05-08

Forgot to remove the original proposed fix.

3687. By Christopher Townsend on 2013-05-08

Remove the manual test since there is some test coverage now.

3686. By Christopher Townsend on 2013-05-08

Re-work how the handling of minimized unredirected fullscreen windows is done based on Sam Spilbury's comments in the original MP.

3685. By Christopher Townsend on 2013-05-01

Fixed issue where minimizing an unredirect full screen window would repaint the full screen window after minimizing it even though it isn't really there.

3684. By MC Return on 2013-04-28

Ring Switcher .xml cleanup:

Better description of the "Ring Switcher".
Uppercase for titles.
More precise names for the tabs.
Improved tooltip wording and descriptions.
Changed the order of options in "General Options" tab:
"Ring Windows" and "Overlay Icon" options are now on top.

No settings have been changed.

Approved by PS Jenkins bot, Sam Spilsbury.

3683. By MC Return on 2013-04-28

Stack Window Switcher (stackswitch):

Declaration and assignment of local variables in one line.
Merged if condition checks.
Use prefix de- and increments.
Removed redundant brackets.
Fixed indentation.

Note:
stackswitch is still excluded from compilation, because
it has not been ported to the new GLES-compatible modern
post-r3320 Compiz codebase yet, so this cannot really be
tested at the moment (except in Compiz pre-r3320).

Nevertheless this MP is needed to reduce the diff size
for the GLES port of this plugin, which will follow soon.

Approved by PS Jenkins bot, Sam Spilsbury.

3682. By MC Return on 2013-04-28

Show Desktop .xml cleanup:

Improved plugin description.
Renamed "Misc. Options" tab to "General"
Improved tooltips.

Approved by PS Jenkins bot, Sam Spilsbury.

3681. By Sam Spilsbury on 2013-04-28

Set libcompizconfig_libdir before the modules get a chance to see it.
(LP: #1173799). Fixes: https://bugs.launchpad.net/bugs/1173799.

Approved by PS Jenkins bot, MC Return.

3680. By MC Return on 2013-04-28

shift.h:
Minor indentation fixes (mostly replaced tabs with spaces).

Approved by PS Jenkins bot, Sam Spilsbury.

3679. By MC Return on 2013-04-27

Refactor screenshot code to make it clearer and also to allow us to take
screenshots in glPaintOutput as opposed to paint ().

Taking screenshots in paint () was probably correct pre-GLES, but isn't
really correct now - we want to be able to read off of the currently
bound scratch framebuffer where we last painted the frame. Reading off
the frontbuffer is an imprecise operation because the contents of both
buffers are really undefined after a swap. In the case where we are
not painting to a scratch framebuffer object, we'll just end up reading
from the backbuffer anyways, which would be correct to do mid-frame.

Also added the new static const GLenums
DRAW_FRAMEBUFFER_BINDING and
READ_FRAMEBUFFER_BINDING to opengl.h.

(LP: #771875). Fixes: https://bugs.launchpad.net/bugs/771875.

Approved by PS Jenkins bot, Sam Spilsbury.