Merge lp:~townsend/compiz/fix-lp1288953 into lp:compiz/0.9.11

Proposed by Christopher Townsend
Status: Merged
Approved by: Christopher Townsend
Approved revision: 3850
Merged at revision: 3853
Proposed branch: lp:~townsend/compiz/fix-lp1288953
Merge into: lp:compiz/0.9.11
Diff against target: 53 lines (+7/-0)
3 files modified
kde/window-decorator-kde4/kdecorationbridge.h (+3/-0)
kde/window-decorator-kde4/window.cpp (+2/-0)
kde/window-decorator-kde4/window.h (+2/-0)
To merge this branch: bzr merge lp:~townsend/compiz/fix-lp1288953
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Eleni Maria Stea Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+214750@code.launchpad.net

Commit message

Add support to build kde4-window-decorator for KDE 4.10 and older.

Description of the change

Add support to build kde4-window-decorator for KDE 4.10 and older.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve
Revision history for this message
Eleni Maria Stea (hikiko) wrote :

lgtm :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'kde/window-decorator-kde4/kdecorationbridge.h'
--- kde/window-decorator-kde4/kdecorationbridge.h 2013-06-25 07:08:45 +0000
+++ kde/window-decorator-kde4/kdecorationbridge.h 2014-04-08 13:11:35 +0000
@@ -26,6 +26,7 @@
26#define KDECORATIONBRIDGE_H26#define KDECORATIONBRIDGE_H
2727
28#include "kdecoration.h"28#include "kdecoration.h"
29#include "kdeversion.h"
29#include <QWidget>30#include <QWidget>
3031
31/**32/**
@@ -42,7 +43,9 @@
42 virtual bool isCloseable() const = 0;43 virtual bool isCloseable() const = 0;
43 virtual bool isMaximizable() const = 0;44 virtual bool isMaximizable() const = 0;
44 virtual MaximizeMode maximizeMode() const = 0;45 virtual MaximizeMode maximizeMode() const = 0;
46#if KDE_IS_VERSION(4,10,90)
45 virtual QuickTileMode quickTileMode() const = 0;47 virtual QuickTileMode quickTileMode() const = 0;
48#endif
46 virtual bool isMinimizable() const = 0;49 virtual bool isMinimizable() const = 0;
47 virtual bool providesContextHelp() const = 0;50 virtual bool providesContextHelp() const = 0;
48 virtual int desktop() const = 0;51 virtual int desktop() const = 0;
4952
=== modified file 'kde/window-decorator-kde4/window.cpp'
--- kde/window-decorator-kde4/window.cpp 2013-06-23 09:03:37 +0000
+++ kde/window-decorator-kde4/window.cpp 2014-04-08 13:11:35 +0000
@@ -226,11 +226,13 @@
226 return wInfo.actionSupported (NET::ActionMax);226 return wInfo.actionSupported (NET::ActionMax);
227}227}
228228
229#if KDE_IS_VERSION(4,10,90)
229KDecoration::QuickTileMode230KDecoration::QuickTileMode
230KWD::Window::quickTileMode (void) const231KWD::Window::quickTileMode (void) const
231{232{
232 return QuickTileNone;233 return QuickTileNone;
233}234}
235#endif
234236
235KDecoration::MaximizeMode237KDecoration::MaximizeMode
236KWD::Window::maximizeMode (void) const238KWD::Window::maximizeMode (void) const
237239
=== modified file 'kde/window-decorator-kde4/window.h'
--- kde/window-decorator-kde4/window.h 2013-06-23 09:48:28 +0000
+++ kde/window-decorator-kde4/window.h 2014-04-08 13:11:35 +0000
@@ -71,7 +71,9 @@
71 virtual bool isCloseable (void) const;71 virtual bool isCloseable (void) const;
72 virtual bool isMaximizable (void) const;72 virtual bool isMaximizable (void) const;
73 virtual MaximizeMode maximizeMode (void) const;73 virtual MaximizeMode maximizeMode (void) const;
74#if KDE_IS_VERSION(4,10,90)
74 virtual QuickTileMode quickTileMode (void) const;75 virtual QuickTileMode quickTileMode (void) const;
76#endif
75 virtual bool isMinimizable (void) const;77 virtual bool isMinimizable (void) const;
76 virtual bool providesContextHelp (void) const;78 virtual bool providesContextHelp (void) const;
77 virtual int desktop (void) const;79 virtual int desktop (void) const;

Subscribers

People subscribed via source and target branches