Merge lp:~townsend/compiz/fix-lp1104236 into lp:compiz/0.9.11

Proposed by Christopher Townsend
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 3847
Merged at revision: 3848
Proposed branch: lp:~townsend/compiz/fix-lp1104236
Merge into: lp:compiz/0.9.11
Diff against target: 13 lines (+2/-1)
1 file modified
plugins/scale/src/scale.cpp (+2/-1)
To merge this branch: bzr merge lp:~townsend/compiz/fix-lp1104236
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email: mp+214269@code.launchpad.net

Commit message

Only fade in and fade out a window when it's hidden if it's not in Show Desktop mode. This allows for a good fade out effect in Unity when exiting Spread while in Show Desktop mode.

Description of the change

Only fade in and fade out a window when it's hidden if it's not in Show Desktop mode. This allows for a good fade out effect in Unity when exiting Spread while in Show Desktop mode.

This goes along with https://code.launchpad.net/~townsend/unity/fix-lp1104236 for the complete solution.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/scale/src/scale.cpp'
2--- plugins/scale/src/scale.cpp 2014-03-04 14:30:25 +0000
3+++ plugins/scale/src/scale.cpp 2014-04-04 14:52:55 +0000
4@@ -260,7 +260,8 @@
5 /* Windows that wouldn't be visible before and after entering
6 * scale mode (because some plugin modified CompWindow::focus)
7 * should be faded in and out */
8- if (window->state () & CompWindowStateHiddenMask)
9+ if (window->state () & CompWindowStateHiddenMask &&
10+ !window->inShowDesktopMode ())
11 {
12 GLfloat factor = 0;
13 GLfloat targetX, targetY, targetScale;

Subscribers

People subscribed via source and target branches