Compiz

lp:~townsend/compiz/fix-lp1031710-0.9.10

Created by Christopher Townsend and last modified
Get this branch:
bzr branch lp:~townsend/compiz/fix-lp1031710-0.9.10
Only Christopher Townsend can upload to this branch. If you are Christopher Townsend please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Christopher Townsend
Project:
Compiz
Status:
Merged

Recent revisions

3782. By Christopher Townsend

Removed logic in the calculateWallOffset() function in the Expo plugin that only accounted for offsetting the expo animation on the left-most and top-most monitor.
Also removed the TestNoOffsetIfOutputIsNotOrigin test since this test is now invalid.

3781. By Łukasz Zemczak

Merge in saucy-released changelog, prepare revision to start off from with the new daily-release

3780. By Łukasz Zemczak

Remove the unity support test patch, we don't need it - also, the version in saucy already has this patch removed.

Approved by PS Jenkins bot, Andrea Azzarone.

3779. By Andrea Azzarone

Use Glib::RefPtr<Glib::Source> in glib_integration_test and compiz core too. After the fix of bug https://bugzilla.gnome.org/show_bug.cgi?id=561885 Glib::Source::~Source is called when both Source::unreference() and SourceCallbackData::destroy_notify_callback() are called. Fixes: https://bugs.launchpad.net/bugs/1214459.

Approved by Christopher Townsend, PS Jenkins bot.

3778. By Andrea Azzarone

Disable show_desktop_key by default on ubuntu. Will provide the same option under the unityshell panel. Fixes: https://bugs.launchpad.net/bugs/1204664.

Approved by PS Jenkins bot, Sam Spilsbury.

3777. By MC Return

plugins/ezoom/src/ezoom.cpp:
Also initialize xtrans and ytrans in the ctors.
Just just enable blending if it is disabled and just
disable it if it was disabled before.
Introduced the variables oWidth, oHeight, halfOWidth and
halfOHeight to speed up following calculations.
Return ASAP, do not calculate possibly redundant stuff.
Declaration and assignment of local variables in one line.
Improved readability.
Added and removed newlines.
Minor indentation fixes.

plugins/ezoom/ezoom.xml.in:
Removed redundant whitespaces from a tooltip.

(LP: #1101572). Fixes: https://bugs.launchpad.net/bugs/1101572.

Approved by Sam Spilsbury, PS Jenkins bot.

3776. By MC Return

cube.cpp, code cleanup:

#include "privates.h", not <privates.h>.
Merged if condition checks.
Declaration of variables, where you need them to improve
the code structure and readability.
Use C++ standard bool for topDir, bottomDir, allCaps and
mCapsPainted[output] (bool true/false instead Bool TRUE/FALSE).
Initialize all of the class member variables in the constructor.
Replaced if (priv->mSky.size () > 0) with if (!priv->mSky.empty ()).
Removed redundant brackets.
Fixed indentation.
Added TODO.

cube.cpp, code speedup:

Do not call optionGetInactiveOpacity () twice, instead save
the value as float inactiveOpacity and use this variable in
the following calculation.
Introduced the variables float halfHsize = hsize / 2.0; and
float tsSize = 360.0f / size; and used those in following
calculations to not have to recalculate those values multiple
times.
Do not calculate M_PI / sides and 2 * M_PI / sides multiple times
in loops, instead save those values in the GLfloats mps and tmps
and use those values inside the loops.
Use GLdouble mDist2 = 0.5 / mDistance; in the GLdouble clipPlane*
arrays, instead of recalculating this value multiple times.
Use GLfloat oneMinusFStepX = 1.0f - fStepX; and
GLfloat oneMinusFStepY = 1.0f - fStepY; instead of calculating
those values multiple times.
Use float outputWidth = outputPtr->width (); and float outputHeight =
outputPtr->height (); instead of calling the functions multiple
times.
Introduced the GLfloat normInvert = 0.5f * invert; and used this
variable instead of recalculating this value multiple times.
Introduced the GLfloats mSkyWidth and mSkyHeight and used those
in the following loops instead of calling mSkySize.width () and
mSkySize.height () multiple times.
Try to avoid redundant GL_BLEND state changes, because OpenGL
will blindly change the global state, no matter what it currently
is set to and that state change is expensive. So we query and
save the actual blending state in the variable GLboolean
glBlendEnabled = glIsEnabled (GL_BLEND); and just enable it if
it isn't already and just disable it, if it was disabled before.

(LP: #1101422, LP: #1195977)

cube.cpp, other fixes:

Return false in function PrivateCubeScreen::updateGeometry (int, int)
if sides should ever be 0, which should never happen, but should make
Coverity happy.

(LP: #1101541)

Initialize all class member variables in the PrivateCubeScreen::
PrivateCubeScreen (CompScreen *) constructor.
(mTc, mNOutput, mOutput, mOutputMask, mCleared, mCapsPainted)

(LP: #1101575). Fixes: https://bugs.launchpad.net/bugs/1101422, https://bugs.launchpad.net/bugs/1101541, https://bugs.launchpad.net/bugs/1101575.

Approved by Sam Spilsbury, PS Jenkins bot.

3775. By Sami Jaktholm

Decor: Use maximized border extents only if window is fully maximized.

The decorator draws a normal border around semi-maximized windows. When
maximized border extents were used for semi-maximized windows, compiz didn't
reserve any space for the border in its geometry calculations.

At least following problems are a result of this behavior:
- Semi-maximized windows have 1px borders drawn on adjacent workspaces
  (LP: #986051).
- Grid placed window overlaps the adjacent viewport (LP: #898870). Fixes: https://bugs.launchpad.net/bugs/898870, https://bugs.launchpad.net/bugs/986051.

Approved by PS Jenkins bot, Sam Spilsbury.

3774. By Sam Spilsbury

Bump VERSION to 0.9.10.2

3773. By Sam Spilsbury

Release version 0.9.10.0

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:compiz/0.9.11
This branch contains Public information 
Everyone can see this information.