Merge lp:~townsend/compiz/fix-expo-clicks into lp:compiz/0.9.12

Proposed by Christopher Townsend
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 3939
Merged at revision: 3945
Proposed branch: lp:~townsend/compiz/fix-expo-clicks
Merge into: lp:compiz/0.9.12
Diff against target: 55 lines (+11/-6)
1 file modified
plugins/expo/src/expo.cpp (+11/-6)
To merge this branch: bzr merge lp:~townsend/compiz/fix-expo-clicks
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Stephen M. Webb Approve
Review via email: mp+255081@code.launchpad.net

Commit message

Expo plugin: Make sure the Expo animation is completed before allowing clicks to be handled.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

Looks fine.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/expo/src/expo.cpp'
2--- plugins/expo/src/expo.cpp 2014-06-24 18:40:39 +0000
3+++ plugins/expo/src/expo.cpp 2015-04-02 13:31:14 +0000
4@@ -48,7 +48,7 @@
5 CompAction::State state,
6 CompOption::Vector &options)
7 {
8- if (expoMode)
9+ if (expoMode && expoCam == 1.0f)
10 {
11 dndState = DnDStart;
12 action->setState (action->state () | CompAction::StateTermButton);
13@@ -65,7 +65,7 @@
14 CompAction::State state,
15 CompOption::Vector &options)
16 {
17- if (dndState == DnDDuring || dndState == DnDStart)
18+ if (expoCam == 1.0f && (dndState == DnDDuring || dndState == DnDStart))
19 {
20 if (dndWindow)
21 finishWindowMovement ();
22@@ -141,10 +141,13 @@
23 if (dndState != DnDNone)
24 dndFini (action, state, options);
25
26- if (state & CompAction::StateCancel)
27- vpUpdateMode = VPUpdatePrevious;
28- else
29- vpUpdateMode = VPUpdateMouseOver;
30+ if (expoCam == 1.0f)
31+ {
32+ if (state & CompAction::StateCancel)
33+ vpUpdateMode = VPUpdatePrevious;
34+ else
35+ vpUpdateMode = VPUpdateMouseOver;
36+ }
37
38 dndState = DnDNone;
39 dndWindow = NULL;
40@@ -324,6 +327,7 @@
41
42 case ButtonPress:
43 if (expoMode &&
44+ expoCam == 1.0f &&
45 event->xbutton.button == Button1 &&
46 event->xbutton.root == screen->root ())
47 {
48@@ -354,6 +358,7 @@
49
50 case ButtonRelease:
51 if (expoMode &&
52+ expoCam == 1.0f &&
53 event->xbutton.button == Button1 &&
54 event->xbutton.root == screen->root ())
55 {

Subscribers

People subscribed via source and target branches