Merge lp:~townsend/compiz/fix-deco-under-panel into lp:compiz/0.9.11

Proposed by Christopher Townsend
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 3862
Merged at revision: 3863
Proposed branch: lp:~townsend/compiz/fix-deco-under-panel
Merge into: lp:compiz/0.9.11
Diff against target: 35 lines (+7/-0)
2 files modified
src/window.cpp (+6/-0)
src/window/extents/src/windowextents.cpp (+1/-0)
To merge this branch: bzr merge lp:~townsend/compiz/fix-deco-under-panel
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+218706@code.launchpad.net

Commit message

Fix issue where window decorations would be placed under the Panel when opening a new window from an already open window. This is due to the already open window being taller or just as tall without be maximized than the workspace.

Description of the change

Fix issue where window decorations would be placed under the Panel when opening a new window from an already open window. This is due to the already open window being taller or just as tall without be maximized than the workspace.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
3862. By Christopher Townsend

Also account for CenterGravity when adjusting the y axis placement.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Cool, this works well in all the cases I've tested.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/window.cpp'
2--- src/window.cpp 2014-04-09 15:52:47 +0000
3+++ src/window.cpp 2014-05-12 19:26:22 +0000
4@@ -6664,6 +6664,9 @@
5
6 if (xwc.x < workarea.x ())
7 xwc.x = workarea.x () + movement.x ();
8+
9+ if (xwc.x - boffset.x () < workarea.x ())
10+ xwc.x += boffset.x ();
11 }
12
13 if (xwc.y + xwc.height > workarea.y2 ())
14@@ -6672,6 +6675,9 @@
15
16 if (xwc.y < workarea.y ())
17 xwc.y = workarea.y () + movement.y ();
18+
19+ if (xwc.y - boffset.y () < workarea.y ())
20+ xwc.y += boffset.y ();
21 }
22
23 if (priv->actions & CompWindowActionResizeMask)
24
25=== modified file 'src/window/extents/src/windowextents.cpp'
26--- src/window/extents/src/windowextents.cpp 2014-03-10 12:53:17 +0000
27+++ src/window/extents/src/windowextents.cpp 2014-05-12 19:26:22 +0000
28@@ -43,6 +43,7 @@
29 case NorthGravity:
30 case NorthWestGravity:
31 case NorthEastGravity:
32+ case CenterGravity:
33 rv.setY (extents.top);
34 break;
35 case SouthGravity:

Subscribers

People subscribed via source and target branches