Merge lp:~townsend/click/no-follow-symlinks into lp:click

Proposed by Christopher Townsend
Status: Superseded
Proposed branch: lp:~townsend/click/no-follow-symlinks
Merge into: lp:click
Diff against target: 12 lines (+1/-1)
1 file modified
click/install.py (+1/-1)
To merge this branch: bzr merge lp:~townsend/click/no-follow-symlinks
Reviewer Review Type Date Requested Status
Michael Vogt Approve
Review via email: mp+271531@code.launchpad.net

This proposal has been superseded by a proposal from 2015-09-18.

Commit message

Don't follow symlinks when stat()ing files.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, this looks good.

review: Approve

Unmerged revisions

461. By CI Train Bot Account

Releasing 0.4.39.1+15.10.20150702-0ubuntu1

460. By CI Train Bot Account

* lp:~mvo/click/lp1456328-15.10-devlibs:
  - add ubuntu-sdk-15.10-dev1
  - remove ubuntu-core-15.04-dev1

459. By CI Train Bot Account

Releasing 0.4.39

458. By CI Train Bot Account

* handle "IP NOT FOUND" error (LP: #1433234)
* switch the default click chroot framework to ubuntu-sdk-14.04

457. By CI Train Bot Account

Releasing 0.4.38.5

456. By Sebastien Bacher

Don't try to replace initctl if it's not there Fixes: #1430436
Approved by: Colin Watson

455. By CI Train Bot Account

Releasing 0.4.38.4

454. By Michael Vogt

Click 0.4.38: stop apps when uninstalling them, fix crash on empty db, add --ignore option to click build, fix framework validation for snappy frameworks Fixes: #1219912, #1324853, #1330770, #1379657, #1393698, #1418086

453. By CI Train Bot Account

Releasing 0.4.37

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'click/install.py'
2--- click/install.py 2014-12-03 12:42:21 +0000
3+++ click/install.py 2015-09-17 19:24:25 +0000
4@@ -418,7 +418,7 @@
5 for dirpath, dirnames, filenames in os.walk(inst_dir):
6 for entry in dirnames + filenames:
7 entry_path = os.path.join(dirpath, entry)
8- entry_mode = os.stat(entry_path).st_mode
9+ entry_mode = os.lstat(entry_path).st_mode
10 new_entry_mode = entry_mode | stat.S_IRGRP | stat.S_IROTH
11 if entry_mode & stat.S_IXUSR:
12 new_entry_mode |= stat.S_IXGRP | stat.S_IXOTH

Subscribers

People subscribed via source and target branches