Code review comment for lp:~toshio/loggerhead/mod_wsgi

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Toshio,

Thanks for this. I wonder whether we ought to put the various files into a contrib/mod_wsgi directory instead of putting them into the project root. What do you think?

Some minor doc tweaks:

* loggehead -> Loggerhead :-)
* "bazaar conf" -> bazaar.conf
* "Loggerhead's doc directory" assumes installation via a package manager doesn't it?

On the legal side, loggerhead.wsgi needs a Copyright 2010 Canonical line added above the GPL stuff. Could you please also sign the Canonical Contributor Agreement? See http://www.canonical.com/contributors.

Forgive my ignorance but how does the MANIFEST.in file come into play?

review: Needs Information

« Back to merge proposal