Merge lp:~tormodvolden/acpi-support/nohdparm-option into lp:acpi-support

Proposed by Tormod Volden on 2009-09-28
Status: Needs review
Proposed branch: lp:~tormodvolden/acpi-support/nohdparm-option
Merge into: lp:acpi-support
Diff against target: 26 lines
2 files modified
debian/changelog (+6/-0)
start.d/90-hdparm.sh (+2/-0)
To merge this branch: bzr merge lp:~tormodvolden/acpi-support/nohdparm-option
Reviewer Review Type Date Requested Status
Steve Langasek Disapprove on 2009-10-01
Review via email: mp+12550@code.launchpad.net
To post a comment you must log in.
Steve Langasek (vorlon) wrote :

Given that acpi-support is deprecated, and really shouldn't be in charge of invoking hdparm on startup, I don't think we should do this. We should focus instead on getting the start-time hdparm handling moved to the udev rule and consolidated.

review: Disapprove
Tormod Volden (tormodvolden) wrote :

> Given that acpi-support is deprecated, and really shouldn't be in charge of
> invoking hdparm on startup, I don't think we should do this. We should focus
> instead on getting the start-time hdparm handling moved to the udev rule and
> consolidated.

But that would be a long-time focus and certainly not for Karmic. My patch here is perfectly non-intrusive and can only help for those of us who have problems with hdparm. The "nohdparm" option is honoured by other packages using hdparm, for a good reason.

It seems non-consistent that we offer the "nohdparm" option but fail to probe for it in one package.

It is not a this instead of that question. Deprecated or not, we still ship acpi-support.

Unmerged revisions

150. By Tormod Volden on 2009-09-28

add check for nohdparm boot option

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-09-23 12:45:26 +0000
3+++ debian/changelog 2009-09-28 20:35:21 +0000
4@@ -1,3 +1,9 @@
5+acpi-support (0.127) UNRELEASED; urgency=low
6+
7+ * start.d/90-hdparm.sh: add check for "nohdparm" boot option
8+
9+ -- Tormod Volden <debian.tormod@gmail.com> Mon, 28 Sep 2009 22:23:35 +0200
10+
11 acpi-support (0.126) UNRELEASED; urgency=low
12
13 [ Steve Langasek ]
14
15=== modified file 'start.d/90-hdparm.sh'
16--- start.d/90-hdparm.sh 2009-01-15 14:22:16 +0000
17+++ start.d/90-hdparm.sh 2009-09-28 20:35:21 +0000
18@@ -7,6 +7,8 @@
19 # very useful for shock protection.
20 #
21
22+grep -qw nohdparm /proc/cmdline && exit
23+
24 . /usr/share/acpi-support/power-funcs
25
26 DO_HDPARM=y

Subscribers

People subscribed via source and target branches