Merge lp:~tormodvolden/acpi-support/nohdparm-option into lp:acpi-support

[Tormod Volden]

[Steve Langasek (vorlon)]

Given that acpi-support is deprecated, and really shouldn't be in charge of invoking hdparm on startup, I don't think we should do this. We should focus instead on getting the start-time hdparm handling moved to the udev rule and consolidated.

review: Disapprove

[Tormod Volden (tormodvolden)]

> Given that acpi-support is deprecated, and really shouldn't be in charge of
> invoking hdparm on startup, I don't think we should do this. We should focus
> instead on getting the start-time hdparm handling moved to the udev rule and
> consolidated.

But that would be a long-time focus and certainly not for Karmic. My patch here is perfectly non-intrusive and can only help for those of us who have problems with hdparm. The "nohdparm" option is honoured by other packages using hdparm, for a good reason.

It seems non-consistent that we offer the "nohdparm" option but fail to probe for it in one package.

It is not a this instead of that question. Deprecated or not, we still ship acpi-support.

Unmerged revisions

150. By Tormod Volden on 2009-09-28

add check for nohdparm boot option

=== modified file 'debian/changelog'
--- debian/changelog	2009-09-23 12:45:26 +0000
+++ debian/changelog	2009-09-28 20:35:21 +0000
@@ -1,3 +1,9 @@
+acpi-support (0.127) UNRELEASED; urgency=low
+
+  * start.d/90-hdparm.sh: add check for "nohdparm" boot option
+
+ -- Tormod Volden <[e-mail]>  Mon, 28 Sep 2009 22:23:35 +0200
+
 acpi-support (0.126) UNRELEASED; urgency=low
 
   [ Steve Langasek ]

=== modified file 'start.d/90-hdparm.sh'
--- start.d/90-hdparm.sh	2009-01-15 14:22:16 +0000
+++ start.d/90-hdparm.sh	2009-09-28 20:35:21 +0000
@@ -7,6 +7,8 @@
 # very useful for shock protection.
 #
 
+grep -qw nohdparm /proc/cmdline && exit
+
 . /usr/share/acpi-support/power-funcs
 
 DO_HDPARM=y