Merge lp:~torkvemada/quickly/packageextras into lp:quickly

Proposed by Vsevolod Velichko
Status: Merged
Merged at revision: 682
Proposed branch: lp:~torkvemada/quickly/packageextras
Merge into: lp:quickly
Diff against target: 49 lines (+9/-3)
1 file modified
data/templates/ubuntu-application/share.py (+9/-3)
To merge this branch: bzr merge lp:~torkvemada/quickly/packageextras
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+115279@code.launchpad.net

Description of the change

'quickly release' option that will package for ppa as for 'extras'

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

As discussde on IRC, I think this should be in quickly share --extra to test the extra repository integration there, not in release.

review: Needs Fixing
lp:~torkvemada/quickly/packageextras updated
677. By Vsevolod Velichko

Move --extras packaging to share rather than to release command

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks for your work here! Merging :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/templates/ubuntu-application/share.py'
2--- data/templates/ubuntu-application/share.py 2011-07-22 10:47:34 +0000
3+++ data/templates/ubuntu-application/share.py 2012-07-24 10:26:53 +0000
4@@ -33,14 +33,15 @@
5
6 launchpad = None
7 ppa_name = None
8+for_extras = False
9 i = 0
10 args = []
11 argv = sys.argv
12
13-options = ["--ppa",]
14+options = ["--ppa", "--extras",]
15
16 def usage():
17- templatetools.print_usage(_('quickly share [--ppa <ppa | group/ppa>]'))
18+ templatetools.print_usage(_('quickly share [--extras] [--ppa <ppa | group/ppa>]'))
19 def help():
20 print _("""Updates your PPA with the the latest saved project changes.
21
22@@ -57,6 +58,9 @@
23 the package three times since then, another run of 'quickly share' will
24 use a new version of 10.07.2-public4.
25
26+Passing --extras will create a package similar to one created by
27+the "quickly package --extras" command. It will install files into /opt.
28+
29 You can optionally run 'quickly package' and test your package to make
30 sure it installs as expected.""")
31 def shell_completion(argv):
32@@ -84,6 +88,8 @@
33 else:
34 cmd = commands.get_command('share', 'ubuntu-application')
35 templatetools.usage_error(_("No PPA provided."), cmd=cmd)
36+ elif arg == '--extras':
37+ for_extras = True
38 else:
39 cmd = commands.get_command('share', 'ubuntu-application')
40 templatetools.usage_error(_("Unknown option: %s." % arg), cmd=cmd)
41@@ -148,7 +154,7 @@
42 sys.exit(1)
43
44 # creation/update debian packaging
45-return_code = packaging.updatepackaging()
46+return_code = packaging.updatepackaging(installopt=for_extras)
47 if return_code != 0:
48 print _("ERROR: can't create or update ubuntu package")
49 sys.exit(1)

Subscribers

People subscribed via source and target branches