Merge lp:~toote/lalita/url-rename into lp:lalita

[Matías Bellone]

Agrega la opción de renombrar URLs en la base de datos.

Muy útil para poder buscar links sin título, en particular imágenes o páginas que no fueron parseadas correctamente.

También corrige un problema en la configuración por defecto al reportar una URL ya que el ":" al final de la misma pasa a ser parte de la URL

[Facundo Batista (facundo)]

It's better to do...

  self.say(channel, u"%s: necesito un ID a renombrar válido", user)

...than using '%' there, to be able to build a translation table later.

Also, it's funny the comparison len(what) -1 == 0

You should include tests for this, but as the module is not tested at all, it could be ok.

review: Needs Fixing

[lp:~toote/lalita/url-rename]

171. By Matías Bellone <email address hidden> on 2011-03-01

Corrected funny conditional and .say invocations to be translation-friendly

[Facundo Batista (facundo)]

Like it

review: Approve

=== modified file 'lalita/plugins/url.py'
--- lalita/plugins/url.py	2010-11-14 18:54:59 +0000
+++ lalita/plugins/url.py	2011-03-01 21:55:37 +0000
@@ -38,7 +38,7 @@
         self.config= dict (
             block_size=4096,
             in_format=u'%(poster)s: [#%(id)d] %(title)s',
-            found_format=u'[#%(id)d] %(url)s: %(title)s [by %(poster)s, %(date)s, %(time)s]',
+            found_format=u'[#%(id)d] %(url)s : %(title)s [by %(poster)s, %(date)s, %(time)s]',
             guess_encoding=0.0,
             )
         self.config.update (config)
@@ -49,6 +49,7 @@
 
         self.register(self.events.COMMAND, self.dig, ['dig'])
         self.register(self.events.COMMAND, self.delete, ['del'])
+        self.register(self.events.COMMAND, self.rename, ['rename'])
 
         self.urlsFound= 0
         self.urlsFailed= 0
@@ -169,6 +170,40 @@
                 promise.addErrback (self.failed, user, channel, url, date, time)
                 return promise
 
+    def rename(self, user, channel, command, *what):
+        u'''Renombra el título de una URL anterior'''
+        self.logger.debug(u'renaming %s', what)
+
+        if len(what) < 2:
+            # no arguments or missing new title
+            self.say(channel,
+                     u"%s: necesito un ID y el nuevo título para poder renombrar", user)
+            return
+        
+        try:
+            url_id = int(what[0])
+        except ValueError:
+            self.say(channel,
+                     u"%s: necesito un ID a renombrar válido", user)
+            return
+
+        self.cursor.execute('''select title, poster from url where id = ?''', (url_id, ))
+
+        result= list (self.cursor.fetchone ())
+        
+        if not result:
+            self.say(channel,
+                     '%s: 404 ID %s not found', user, url_id)
+            return
+
+        new_title = ' '.join(what[1:])
+
+        self.logger.debug('changing urlID %s from "%s" to "%s"', url_id, result[0], new_title)
+        self.cursor.execute('''update url SET title = ? where id = ?''', (new_title, url_id))
+        self.conn.commit()
+        self.say(channel,
+                 '%s: [#%s] renamed to "%s"', user, url_id, new_title)
+
     ##### encoding detectors #####
     def pageContentType(self, page):
         encoding = None