Code review comment for lp:tomdroid/beta

Revision history for this message
Stefan Hammer (j-4-deactivatedaccount) wrote :

It looks like the dialogue is opened and instantly moves to the background on android 4 and the dialogue is closing the listactivity on android 2.3.
after a lot of tries, the conflict handling seems to work, but the dialog is not shown properly on top of the app. If you do not respond to the sync dialouge (because it is not shown for some reason), sync stops at this point and that was why I got such weird results last time.

Further, I realised that at some point, when saving the note with the back-button, the app starts to sync and instantly overwrites the local changes with the server version. (maybe when the sync is still in progress due to not responding to the dialogue?)
We need some time-out for the sync I suppose, in case the dialogue is cancelled or not seen for some reason.
However, the procedure is not really stable at the moment... @noahy: if you have time maybe you can debug it a little (most importantly the sync dialouge should be shown on all android versions on top of the app). Otherwise, I will have a look at it later next week.

Happy coding,
Stefan

> I'm not sure about all of the sync problems you are having... two-way sync
> works fine, even conflict resolution for me on Ubuntu One sync. The SDCard
> was missing an update call for the last-sync-date, so it always thought there
> was a new file. Should be fixed now.

« Back to merge proposal