Code review comment for lp:tomdroid/beta

Revision history for this message
Stefan Hammer (j-4-deactivatedaccount) wrote :

I changed the code to always autosave, as we risk loss of data otherwise (eg through a phone call) and it is anyway the same behaviour as Tomboy. A "Discard changes" should help to discard huge mistakes (such as everything deleted,...).
Further, I fixed crashes with the shortcut and shortcuthelper activity.
The updated test build is again available here: http://goo.gl/fKg6N

I still have to fix:
Changing the Text size in EditView only works, if you select some text, but not if you change the size and start typing afterwards.
Bug: On androids 1.6 notes do not show up in the list if one note is corrupt and cannot be parsed. Otherwise it works great from 1.6 to 4.1
I found another serious bug: clicking on the XML-Button changes the textview to XML content - clicking again changes it back, but clicking a third time deletes the whole content!
I think we have to change the sync behaviour to check every note separately if we have to push, pull or start a conflict handling (in Tomboy: copy note to new one). I already lost several edits because I don't sync before edit and then push the notes to the server... very bad!

Did I forget any already mentioned bugs/issues in this list?

« Back to merge proposal