Merge lp:~tomdroid-dev/tomdroid/sdsync-remove-notes into lp:~tomdroid-maintainers/tomdroid/main

Proposed by Stefan Hammer
Status: Merged
Merged at revision: 287
Proposed branch: lp:~tomdroid-dev/tomdroid/sdsync-remove-notes
Merge into: lp:~tomdroid-maintainers/tomdroid/main
Diff against target: 39 lines (+11/-0)
2 files modified
NEWS (+1/-0)
src/org/tomdroid/sync/sd/SdCardSyncService.java (+10/-0)
To merge this branch: bzr merge lp:~tomdroid-dev/tomdroid/sdsync-remove-notes
Reviewer Review Type Date Requested Status
Olivier Bilodeau Approve
Review via email: mp+100338@code.launchpad.net

Description of the change

fixes bug #533933 with a few lines!

To post a comment you must log in.
288. By Stefan Hammer

mistake in comment

Revision history for this message
Olivier Bilodeau (plaxx) wrote :

if you tested well, like you usually do, then go ahead and merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2012-03-31 22:07:31 +0000
3+++ NEWS 2012-04-01 15:21:22 +0000
4@@ -13,6 +13,7 @@
5
6 -------------------------------------------------------------------------------
7 Versoin 0.?? released on ??
8+* SD card synchronisation now removes deleted messages from db (Stefan Hammer, lp:533933 )
9 * Can specify folder for SD Card Sync (ie: dropbox) (Stefan Hammer, lp:837119)
10 * Creating home-screen shortcuts to notes is now possible (Piotr Adamski,
11 lp:882703)
12
13=== modified file 'src/org/tomdroid/sync/sd/SdCardSyncService.java'
14--- src/org/tomdroid/sync/sd/SdCardSyncService.java 2012-03-31 19:30:28 +0000
15+++ src/org/tomdroid/sync/sd/SdCardSyncService.java 2012-04-01 15:21:22 +0000
16@@ -39,6 +39,7 @@
17 import javax.xml.parsers.SAXParser;
18 import javax.xml.parsers.SAXParserFactory;
19 import java.io.*;
20+import java.util.ArrayList;
21 import java.util.regex.Matcher;
22 import java.util.regex.Pattern;
23
24@@ -115,6 +116,15 @@
25 return;
26 }
27
28+ // Delete the notes that are not in the folder any more
29+ ArrayList<String> remoteGuids = new ArrayList<String>();
30+
31+ for (int i = 0; i < fileList.length; i++) {
32+ // make a list with all note guids stored in filenames
33+ remoteGuids.add(fileList[i].getName().replace(".note", ""));
34+ }
35+ deleteNotes(remoteGuids);
36+
37 // every but the last note
38 for(int i = 0; i < fileList.length-1; i++) {
39 // TODO better progress reporting from within the workers

Subscribers

People subscribed via source and target branches