Merge lp:~tombeckmann/switchboard/quantal-crash into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Tom Beckmann
Status: Merged
Merged at revision: 331
Proposed branch: lp:~tombeckmann/switchboard/quantal-crash
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 42 lines (+8/-3)
1 file modified
Switchboard/switchboard-app.vala (+8/-3)
To merge this branch: bzr merge lp:~tombeckmann/switchboard/quantal-crash
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+129588@code.launchpad.net

Description of the change

Don't crash on quantal systems.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Switchboard/switchboard-app.vala'
2--- Switchboard/switchboard-app.vala 2012-09-23 22:43:12 +0000
3+++ Switchboard/switchboard-app.vala 2012-10-14 12:57:19 +0000
4@@ -77,7 +77,9 @@
5 private const string[] SUPPORTED_GETTEXT_DOMAINS_KEYS = {"X-Ubuntu-Gettext-Domain", "X-GNOME-Gettext-Domain"};
6
7 public SwitchboardApp () {
8-
9+ }
10+
11+ void build () {
12 main_window = new Gtk.Window();
13
14 // Set up defaults
15@@ -193,6 +195,8 @@
16 return false;
17 });
18 }
19+
20+ progress_toolitem.hide ();
21 }
22
23 void shut_down () {
24@@ -499,7 +503,9 @@
25 toolbar.insert (create_appmenu (new Gtk.Menu ()), -1);
26 }
27
28- public override void activate () {}
29+ public override void activate () {
30+ build ();
31+ }
32 }
33
34 static const OptionEntry[] entries = {
35@@ -527,7 +533,6 @@
36
37 // In the future, the plug_root_dir should be overridable by CLI flags.
38 var switchboard_app = new SwitchboardApp ();
39- switchboard_app.progress_toolitem.hide();
40
41 Bus.own_name (BusType.SESSION, "org.elementary.switchboard",
42 BusNameOwnerFlags.NONE,

Subscribers

People subscribed via source and target branches

to all changes: