Merge lp:~tombeckmann/switchboard/focus-search into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Tom Beckmann
Status: Rejected
Rejected by: David Gomes
Proposed branch: lp:~tombeckmann/switchboard/focus-search
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 27 lines (+9/-1)
1 file modified
Switchboard/switchboard-app.vala (+9/-1)
To merge this branch: bzr merge lp:~tombeckmann/switchboard/focus-search
Reviewer Review Type Date Requested Status
David Gomes (community) Disapprove
Cody Garver (community) Needs Fixing
Review via email: mp+125897@code.launchpad.net

Description of the change

This redirects all input to the searchbox.

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Conflicts :(

review: Needs Fixing
Revision history for this message
David Gomes (davidgomes) wrote :

Disapproving, a new branch will be made.

review: Disapprove

Unmerged revisions

313. By Tom Beckmann

Redirect all input to the search box

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Switchboard/switchboard-app.vala'
2--- Switchboard/switchboard-app.vala 2012-09-22 20:12:56 +0000
3+++ Switchboard/switchboard-app.vala 2012-09-23 20:50:24 +0000
4@@ -85,7 +85,7 @@
5 main_window.icon_name = APP_ICON;
6
7 // Set up window
8- main_window.set_size_request (842, 468);
9+ main_window.set_size_request (822, 468);
10 main_window.window_position = Gtk.WindowPosition.CENTER;
11 main_window.destroy.connect (shut_down);
12 setup_toolbar ();
13@@ -196,6 +196,14 @@
14 return false;
15 });
16 }
17+
18+ main_window.key_press_event.connect ((event) => {
19+ if (main_window.get_focus () != search_box) {
20+ search_box.grab_focus ();
21+ }
22+
23+ return false;
24+ });
25 }
26
27 bool draw_white (Cairo.Context cr) {

Subscribers

People subscribed via source and target branches

to all changes: