Merge lp:~tombeckmann/audience/aspect-ration-second-try into lp:~audience-members/audience/trunk
Proposed by
Tom Beckmann
Status: | Merged |
---|---|
Approved by: | Viko Adi Rahmawan |
Approved revision: | 467 |
Merged at revision: | 499 |
Proposed branch: | lp:~tombeckmann/audience/aspect-ration-second-try |
Merge into: | lp:~audience-members/audience/trunk |
Diff against target: |
153 lines (+66/-12) 2 files modified
src/Audience.vala (+61/-7) src/Widgets/VideoPlayer.vala (+5/-5) |
To merge this branch: | bzr merge lp:~tombeckmann/audience/aspect-ration-second-try |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Viko Adi Rahmawan (community) | Approve | ||
Artem Anufrij (community) | ratio | Needs Fixing | |
Review via email: mp+242789@code.launchpad.net |
Commit message
fix ratio constrain in CSD
Description of the change
I think it's working now, so I'm proposing it for being merged. I'm not 100% sure it will work seamlessly in all cases though, so I haven't removed the debug prints yet.
The system works by locking the window's aspect ratio after a resize has finished or while it pauses. This is required, as outlined before, because of the CSD, which adds a constant padding around the video, so in turn the entire window's aspect ratio is no longer constant when resized.
To post a comment you must log in.
Hey Tom,
"audience" crashes on add a new video into playlist.
It doesn't happening on currently version.