Merge lp:~tomasgroth/openlp/packaging-tag-override into lp:openlp/packaging

Proposed by Tomas Groth
Status: Merged
Merged at revision: 38
Proposed branch: lp:~tomasgroth/openlp/packaging-tag-override
Merge into: lp:openlp/packaging
Diff against target: 43 lines (+15/-10)
1 file modified
builders/builder.py (+15/-10)
To merge this branch: bzr merge lp:~tomasgroth/openlp/packaging-tag-override
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Review via email: mp+349434@code.launchpad.net

Commit message

Add an option for providing tag and revision to avoid using bzr. Useful on Appveyor where bzr does not work.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'builders/builder.py'
2--- builders/builder.py 2017-03-28 00:05:46 +0000
3+++ builders/builder.py 2018-07-12 20:11:54 +0000
4@@ -160,6 +160,8 @@
5 parser.add_argument('--skip-translations', action='store_true', default=False,
6 help='Do NOT update the language translation files')
7 parser.add_argument('--debug', action='store_true', default=False, help='Create a debug build')
8+ parser.add_argument('--tag-override', metavar='<tag>-bzr<revision>', default=None,
9+ help='Override tag and revision, should be in format <tag>-bzr<revision>')
10 self.add_extra_args(parser)
11 self.args = parser.parse_args()
12
13@@ -297,17 +299,20 @@
14 """
15 self._print('Writing version file...')
16 if not self.args.release:
17- # This is a development build, get the tag and revision
18- output = self._bzr('tags', self.branch_path, err_msg='Error running bzr tags')
19- lines = output.splitlines()
20- if len(lines) == 0:
21- tag = '0.0.0'
22- revision = '0'
23+ if self.args.tag_override:
24+ self.version = self.args.tag_override
25 else:
26- tag, revision = lines[-1].split()
27- output = self._bzr('log', self.branch_path, ['--line', '-r', '-1'], 'Error running bzr log')
28- revision = output.split(':')[0]
29- self.version = '{tag}-bzr{revision}'.format(tag=tag, revision=revision)
30+ # This is a development build, get the tag and revision
31+ output = self._bzr('tags', self.branch_path, err_msg='Error running bzr tags')
32+ lines = output.splitlines()
33+ if len(lines) == 0:
34+ tag = '0.0.0'
35+ revision = '0'
36+ else:
37+ tag, revision = lines[-1].split()
38+ output = self._bzr('log', self.branch_path, ['--line', '-r', '-1'], 'Error running bzr log')
39+ revision = output.split(':')[0]
40+ self.version = '{tag}-bzr{revision}'.format(tag=tag, revision=revision)
41 # Write the version to the version file
42 with open(os.path.join(self.dist_path, '.version'), 'w') as version_file:
43 version_file.write(str(self.version))

Subscribers

People subscribed via source and target branches