Merge lp:~tomasgroth/openlp/packaging-appveyor into lp:openlp/packaging

Proposed by Tomas Groth
Status: Merged
Merged at revision: 32
Proposed branch: lp:~tomasgroth/openlp/packaging-appveyor
Merge into: lp:openlp/packaging
Diff against target: 122 lines (+47/-19)
3 files modified
windows/config-appveyor.ini (+23/-0)
windows/config.ini.default (+2/-1)
windows/windows-builder.py (+22/-18)
To merge this branch: bzr merge lp:~tomasgroth/openlp/packaging-appveyor
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Raoul Snyman Approve
Review via email: mp+312202@code.launchpad.net

Description of the change

Added support for MediaInfo windows builds.
Added a appveyor specific config file.
Updated some docs in windows-builder.py.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Looks OK to me

review: Approve
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'windows/config-appveyor.ini'
2--- windows/config-appveyor.ini 1970-01-01 00:00:00 +0000
3+++ windows/config-appveyor.ini 2016-11-30 21:03:31 +0000
4@@ -0,0 +1,23 @@
5+[executables]
6+innosetup = %(progfiles)s\Inno Setup 5\ISCC.exe
7+sphinx = %(pyroot)s\Scripts\sphinx-build.exe
8+pyinstaller = %(here)s\..\..\pyinstaller-develop\pyinstaller.py
9+vcbuild = %(progfiles)s\Microsoft Visual Studio 9.0\VC\vcpackages\vcbuild.exe
10+htmlhelp = %(progfiles)s\HTML Help Workshop\hhc.exe
11+psvince = %(here)s\psvince.dll
12+lrelease = %(sitepackages)s\PyQt5\bin\lrelease.exe
13+portablelauncher = %(here)s\..\..\PortableApps.comLauncher\PortableApps.comLauncherGenerator.exe
14+portableinstaller = %(here)s\..\..\PortableApps.comInstaller\PortableApps.comInstaller.exe
15+mutoolbin = %(here)s\..\..\mupdf-1.9a-windows\mutool.exe
16+mediainfobin = %(here)s\..\..\MediaInfo\MediaInfo.exe
17+
18+[paths]
19+branch = %(projects)s\trunk
20+documentation = %(projects)s\documentation
21+win32icon = %(here)s\OpenLP.ico
22+hooks = %(here)s\..\pyinstaller-hooks
23+portable = %(projects)s\OpenLPPortable
24+
25+[transifex]
26+username =
27+password =
28
29=== modified file 'windows/config.ini.default'
30--- windows/config.ini.default 2016-01-03 21:10:14 +0000
31+++ windows/config.ini.default 2016-11-30 21:03:31 +0000
32@@ -8,7 +8,8 @@
33 lrelease = %(sitepackages)s\PyQt5\bin\lrelease.exe
34 portablelauncher = %(progfiles)s\PortableApps.comLauncher\PortableApps.comLauncherGenerator.exe
35 portableinstaller = %(progfiles)s\PortableApps.comInstaller\PortableApps.comInstaller.exe
36-mudrawbin = %(here)s\..\mupdf-1.8-windows\mudraw.exe
37+mutoolbin = %(here)s\..\mupdf-1.9a-windows\mutool.exe
38+mediainfobin = %(here)s\..\MediaInfo\MediaInfo.exe
39
40 [paths]
41 branch = %(projects)s\trunk
42
43=== modified file 'windows/windows-builder.py'
44--- windows/windows-builder.py 2016-01-03 21:10:14 +0000
45+++ windows/windows-builder.py 2016-11-30 21:03:31 +0000
46@@ -49,9 +49,8 @@
47 This is used to create the help file.
48
49 PyInstaller
50- PyInstaller should be a git clone of either
51- https://github.com/matysek/pyinstaller branch python3 or
52- https://github.com/pyinstaller/pyinstaller branch python3
53+ PyInstaller should be a git clone of
54+ https://github.com/matysek/pyinstaller branch develop
55
56 Bazaar
57 You need the command line "bzr" client installed.
58@@ -86,16 +85,15 @@
59
60 http://www.makotemplates.org/download.html
61
62-SQLAlchemy Migrate
63- Required for the databases used in OpenLP. The package can be
64- obtained here:
65-
66- http://code.google.com/p/sqlalchemy-migrate/
67-
68 MuPDF
69 Required for PDF support in OpenLP. Download the windows build from
70- mupdf.com, extract it, and set the mudrawbin option in the config file to
71- point to mudraw.exe
72+ mupdf.com, extract it, and set the mutoolbin option in the config file to
73+ point to mutool.exe.
74+
75+MediaInfo
76+ Required for the media plugin. Download the 32-bit CLI windows build from
77+ https://mediaarea.net/nn/MediaInfo/Download/Windows and set the
78+ mediainfobin option in the config file to point to MediaInfo.exe.
79
80 Portable App Builds
81 The following are required if you are planning to make a portable build of
82@@ -212,7 +210,8 @@
83 self.psvince = os.path.abspath(self.config.get('executables', 'psvince'))
84 self.portableinstaller = os.path.abspath(self.config.get('executables', 'portableinstaller'))
85 self.portablelauncher = os.path.abspath(self.config.get('executables', 'portablelauncher'))
86- self.mudraw_bin = os.path.abspath(self.config.get('executables', 'mudrawbin'))
87+ self.mutool_bin = os.path.abspath(self.config.get('executables', 'mutoolbin'))
88+ self.mediainfo_bin = os.path.abspath(self.config.get('executables', 'mediainfobin'))
89 if os.path.exists(os.path.join(self.site_packages, 'PyQt5', 'bin')):
90 # Older versions of the PyQt5 Windows installer put their binaries
91 # in the "bin" directory
92@@ -405,11 +404,16 @@
93 copy(os.path.join(self.helpfile_path, 'OpenLP.chm'), os.path.join(self.dist_path, 'OpenLP.chm'))
94 else:
95 self._print('... WARNING: Windows help file not found')
96- self._print_verbose('... mudraw.exe')
97- if self.mudraw_bin and os.path.isfile(self.mudraw_bin):
98- copy(os.path.join(self.mudraw_bin), os.path.join(self.dist_path, 'mudraw.exe'))
99- else:
100- self._print('... WARNING: mudraw.exe not found')
101+ self._print_verbose('... mutool.exe')
102+ if self.mutool_bin and os.path.isfile(self.mutool_bin):
103+ copy(os.path.join(self.mutool_bin), os.path.join(self.dist_path, 'mutool.exe'))
104+ else:
105+ self._print('... WARNING: mutool.exe not found')
106+ self._print_verbose('... MediaInfo.exe')
107+ if self.mediainfo_bin and os.path.isfile(self.mediainfo_bin):
108+ copy(os.path.join(self.mediainfo_bin), os.path.join(self.dist_path, 'MediaInfo.exe'))
109+ else:
110+ self._print('... WARNING: MediaInfo.exe not found')
111
112 def update_translations(self):
113 """
114@@ -616,7 +620,7 @@
115 self._print_verbose('Windows resources: .......%s', self.winres_path)
116 self._print_verbose('VCBuild path: ............%s', self.vcbuild)
117 self._print_verbose('PPTVIEWLIB path: .........%s', self.pptviewlib_path)
118- self._print_verbose('Mudraw binary ............%s', self.mudraw_bin)
119+ self._print_verbose('Mutool binary ............%s', self.mutool_bin)
120 self._print_verbose('')
121 if not self.args.skip_update:
122 self.update_code()

Subscribers

People subscribed via source and target branches