Merge lp:~tobi-coldtobi/drizzle/drizzle into lp:drizzle

Proposed by coldtobi
Status: Needs review
Proposed branch: lp:~tobi-coldtobi/drizzle/drizzle
Merge into: lp:drizzle
Diff against target: 69 lines (+8/-7)
2 files modified
client/drizzleslap.cc (+5/-4)
drizzled/message/include.am (+3/-3)
To merge this branch: bzr merge lp:~tobi-coldtobi/drizzle/drizzle
Reviewer Review Type Date Requested Status
Drizzle Trunk Pending
Review via email: mp+184154@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

2643. By Tobias Frost <email address hidden>

Fix build for boost >1.54
boost:system needs to be linked in when using boost::thread
boost::progamm-options does not take char* as pointer, reworked
to use std::string

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'client/drizzleslap.cc'
2--- client/drizzleslap.cc 2012-12-13 18:45:19 +0000
3+++ client/drizzleslap.cc 2013-09-05 17:33:49 +0000
4@@ -433,7 +433,8 @@
5 */
6 int main(int argc, char **argv)
7 {
8- char *password= NULL;
9+ std::string stpassword;
10+
11 try
12 {
13 po::options_description commandline_options("Options used only in command line");
14@@ -535,7 +536,7 @@
15 po::options_description client_options("Options specific to the client");
16 client_options.add_options()
17 ("host,h",po::value<string>(&host)->default_value("localhost"),"Connect to the host")
18- ("password,P",po::value<char *>(&password),
19+ ("password,P",po::value<std::string >(&stpassword),
20 "Password to use when connecting to server. If password is not given it's asked from the tty")
21 ("port,p",po::value<uint32_t>(), "Port number to use for connection")
22 ("protocol",po::value<string>(&opt_protocol)->default_value("mysql"),
23@@ -643,13 +644,13 @@
24 {
25 if (not opt_password.empty())
26 opt_password.erase();
27- if (password == PASSWORD_SENTINEL)
28+ if (stpassword == PASSWORD_SENTINEL)
29 {
30 opt_password= "";
31 }
32 else
33 {
34- opt_password= password;
35+ opt_password= stpassword;
36 tty_password= false;
37 }
38 }
39
40=== modified file 'drizzled/message/include.am'
41--- drizzled/message/include.am 2013-01-29 04:33:23 +0000
42+++ drizzled/message/include.am 2013-09-05 17:33:49 +0000
43@@ -40,7 +40,7 @@
44 drizzled_message_libdrizzledmessage_la_CXXFLAGS = ${MESSAGE_AM_CXXFLAGS} ${NO_WERROR}
45
46 drizzled_message_libdrizzledmessage_la_SOURCES = drizzled/message/statement_transform.cc
47-drizzled_message_libdrizzledmessage_la_LIBADD= ${LTLIBPROTOBUF} $(GCOV_LIBS) drizzled/libcharset.la
48+drizzled_message_libdrizzledmessage_la_LIBADD= ${BOOST_LIBS} ${LTLIBPROTOBUF} $(GCOV_LIBS) drizzled/libcharset.la
49
50 nobase_dist_pkginclude_HEADERS+= \
51 drizzled/message/statement_transform.h
52@@ -89,7 +89,7 @@
53 drizzled_message_schema_writer_CXXFLAGS = ${MESSAGE_AM_CXXFLAGS}
54
55 drizzled_message_table_reader_SOURCES = drizzled/message/table_reader.cc
56-drizzled_message_table_reader_LDADD = ${MESSAGE_LDADD}
57+drizzled_message_table_reader_LDADD = ${BOOST_LIBS} ${MESSAGE_LDADD}
58 drizzled_message_table_reader_CXXFLAGS = ${MESSAGE_AM_CXXFLAGS}
59
60 drizzled_message_table_raw_reader_SOURCES = drizzled/message/table_raw_reader.cc
61@@ -104,7 +104,7 @@
62 drizzled_message_table_writer_CXXFLAGS = ${MESSAGE_AM_CXXFLAGS}
63
64 drizzled_message_transaction_writer_SOURCES = drizzled/message/transaction_writer.cc
65-drizzled_message_transaction_writer_LDADD = ${MESSAGE_LDADD} ${top_builddir}/drizzled/algorithm/libhash.la
66+drizzled_message_transaction_writer_LDADD = ${BOOST_LIBS} ${MESSAGE_LDADD} ${top_builddir}/drizzled/algorithm/libhash.la
67 drizzled_message_transaction_writer_CXXFLAGS = ${MESSAGE_AM_CXXFLAGS} ${NO_WERROR}
68
69 EXTRA_DIST += \

Subscribers

People subscribed via source and target branches

to all changes: