Code review comment for ~tobhe/ubuntu/+source/ubuntu-x1e-settings:crd

Revision history for this message
Lukas Märdian (slyon) wrote :

LGTM! Sponsored with a small addition to drop some .deb binaries that slipped into my previous upload.

$ dput ubuntu ../ubuntu-x1e-settings_25.04.6_source.changes
Uploading ubuntu-x1e-settings using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running gpg: check GnuPG signatures before the upload
The .buildinfo file is already signed.
Would you like to use the current signature? [Yn]
Leaving current signature unchanged.
 signfile changes ../ubuntu-x1e-settings_25.04.6_source.changes E3DE869822F99B6CBC35F279BF7DB622B303AC8B

Successfully signed changes file
running nobug: Stop if uploading without any bug reference.
running gitubuntu: Warn if uploading without git-ubuntu Vcs-* entries.
running checksum: verify checksums before uploading
running required-fields: check whether a field is present and non-empty in the changes file
running updatemaintainer: Stop if ubuntu changes are without ubuntu maintainer.
running placeholderbug: Stop if using common placeholder numbers as bug reference.
running ppaforppaonly: Stop uploads to the archive with or to ppa without ~ppa suffix.
running suite-mismatch: check the target distribution for common errors
running check-debs: makes sure the upload contains a binary package
running releasemismatch: Warn about mismatching suffixesg e.g. focal with a XX.YY not being 20.04
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running badauthor: Stop if uploading with root@ or ubuntu@ email adresses.
Uploading ubuntu-x1e-settings_25.04.6.dsc
Uploading ubuntu-x1e-settings_25.04.6.tar.xz
Uploading ubuntu-x1e-settings_25.04.6_source.buildinfo
Uploading ubuntu-x1e-settings_25.04.6_source.changes

review: Approve

« Back to merge proposal