Merge ~tobhe/ubuntu/+source/ubuntu-x1e-settings:crd into ubuntu/+source/ubuntu-x1e-settings:ubuntu/devel

Proposed by Tobias Heider
Status: Merged
Merge reported by: Tobias Heider
Merged at revision: aee6bedd25b5063347723acd41a95b3d1244bfd0
Proposed branch: ~tobhe/ubuntu/+source/ubuntu-x1e-settings:crd
Merge into: ubuntu/+source/ubuntu-x1e-settings:ubuntu/devel
Diff against target: 23 lines (+7/-0)
2 files modified
debian/changelog (+6/-0)
debian/hwe-qcom-x1e-meta.modaliases (+1/-0)
Reviewer Review Type Date Requested Status
Lukas Märdian (community) Approve
Utkarsh Gupta (community) Approve
Tim Andersson (community) Approve
git-ubuntu import Pending
Review via email: mp+483270@code.launchpad.net

Description of the change

Make sure Qualcomm CRD is detected by ubuntu-drivers to automatically install hwe-qcom-x1e-meta. This should make the installer "just work".

See also for more context https://code.launchpad.net/~tobhe/debian-cd/+git/ubuntu/+merge/483269

To post a comment you must log in.
Revision history for this message
Tim Andersson (andersson123) wrote :

LGTM!

review: Approve
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Thanks, it looks good, I'll sponsor the upload once Lukas or someone clarified why are there binaries in https://git.launchpad.net/ubuntu/+source/ubuntu-x1e-settings/tree/TMP.

review: Approve
Revision history for this message
Lukas Märdian (slyon) wrote :

LGTM! Sponsored with a small addition to drop some .deb binaries that slipped into my previous upload.

$ dput ubuntu ../ubuntu-x1e-settings_25.04.6_source.changes
Uploading ubuntu-x1e-settings using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running gpg: check GnuPG signatures before the upload
The .buildinfo file is already signed.
Would you like to use the current signature? [Yn]
Leaving current signature unchanged.
 signfile changes ../ubuntu-x1e-settings_25.04.6_source.changes E3DE869822F99B6CBC35F279BF7DB622B303AC8B

Successfully signed changes file
running nobug: Stop if uploading without any bug reference.
running gitubuntu: Warn if uploading without git-ubuntu Vcs-* entries.
running checksum: verify checksums before uploading
running required-fields: check whether a field is present and non-empty in the changes file
running updatemaintainer: Stop if ubuntu changes are without ubuntu maintainer.
running placeholderbug: Stop if using common placeholder numbers as bug reference.
running ppaforppaonly: Stop uploads to the archive with or to ppa without ~ppa suffix.
running suite-mismatch: check the target distribution for common errors
running check-debs: makes sure the upload contains a binary package
running releasemismatch: Warn about mismatching suffixesg e.g. focal with a XX.YY not being 20.04
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running badauthor: Stop if uploading with root@ or ubuntu@ email adresses.
Uploading ubuntu-x1e-settings_25.04.6.dsc
Uploading ubuntu-x1e-settings_25.04.6.tar.xz
Uploading ubuntu-x1e-settings_25.04.6_source.buildinfo
Uploading ubuntu-x1e-settings_25.04.6_source.changes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 99a2d54..2a7d23f 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+ubuntu-x1e-settings (25.04.6) plucky; urgency=medium
7+
8+ * Add support for Qualcomm CRD (LP: #2103996)
9+
10+ -- Tobias Heider <tobias.heider@canonical.com> Sun, 23 Mar 2025 00:54:43 +0100
11+
12 ubuntu-x1e-settings (25.04.5) plucky; urgency=medium
13
14 * d/control: Move ubuntu-x1e-settings back to arch:arm64 to fix unsatisfiable
15diff --git a/debian/hwe-qcom-x1e-meta.modaliases b/debian/hwe-qcom-x1e-meta.modaliases
16index 4ab3cdb..160b8e6 100644
17--- a/debian/hwe-qcom-x1e-meta.modaliases
18+++ b/debian/hwe-qcom-x1e-meta.modaliases
19@@ -7,3 +7,4 @@ alias dmi:bvnLENOVO:*:pvrYogaSlim714Q8X9* hwe-qcom-x1e-meta
20 alias dmi:bvnMicrosoftCorporation:*:pvrMicrosoftSurfaceLaptop,7thEdition* hwe-qcom-x1e-meta
21 alias dmi:bvnMicrosoftCorporation:*:pvrMicrosoftSurfaceLaptop,11thEdition* hwe-qcom-x1e-meta
22 alias dmi:bvnSAMSUNGELECTRONICS*:*:pnGalaxyBook4Edge* hwe-qcom-x1e-meta
23+alias dmi:bvnQualcomm*:*:pnCRD* hwe-qcom-x1e-meta

Subscribers

People subscribed via source and target branches