Merge ~tobhe/debian-cd/+git/ubuntu:ubuntu/plucky-x1e into ~ubuntu-cdimage/debian-cd/+git/ubuntu:main

Proposed by Tobias Heider
Status: Merged
Merged at revision: df49118d41f959dbd960899221a7d29436fd1809
Proposed branch: ~tobhe/debian-cd/+git/ubuntu:ubuntu/plucky-x1e
Merge into: ~ubuntu-cdimage/debian-cd/+git/ubuntu:main
Diff against target: 15 lines (+4/-0)
1 file modified
tools/boot/plucky/boot-arm64 (+4/-0)
Reviewer Review Type Date Requested Status
Utkarsh Gupta Approve
Michael Hudson-Doyle Approve
Tim Andersson Pending
Review via email: mp+483269@code.launchpad.net

Description of the change

The Qualcomm CRD (Compute Reference Design) is not widely available but this change will allow us to utilize a few more machines to test our 25.04 arm64 ISOs.

The regression potential should be pretty low since it only affects machines with matching Product Vendor smbios string.

To post a comment you must log in.
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

I am sure it makes sense to people who know what this is but can I please ask you to add a bit more descriptive commit message? What prompted this change? How is it affecting the current builds? What's missing? Or?

Apologies for the minor nit pick but looks good otherwise. :)

review: Needs Information
Revision history for this message
Tobias Heider (tobhe) wrote :

Thanks, updated commit message and description to add some more clarity.

Revision history for this message
Michael Hudson-Doyle (mwhudson) :
review: Approve
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Thank you!

review: Approve
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

merged and deployed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tools/boot/plucky/boot-arm64 b/tools/boot/plucky/boot-arm64
2index c57658a..2579dbd 100755
3--- a/tools/boot/plucky/boot-arm64
4+++ b/tools/boot/plucky/boot-arm64
5@@ -138,6 +138,10 @@ if [ "\$system_sku_number" == "Surface_Laptop_7th_Edition_2037" ]; then
6 cmdline="clk_ignore_unused pd_ignore_unused cma=128M"
7 dtb="devicetree /casper/dtbs/x1e80100-microsoft-romulus15.dtb"
8 fi
9+if [ "\$system_product_name" == "CRD" ]; then
10+ cmdline="clk_ignore_unused pd_ignore_unused cma=128M"
11+ dtb="devicetree /casper/dtbs/x1e80100-crd.dtb"
12+fi
13
14 menuentry "Try or Install $HUMANPROJECT" {
15 set gfxpayload=keep

Subscribers

People subscribed via source and target branches