Merge ~toabctl/snap-kubelet:master-explicit-install-mode into snap-kubelet:master

[Thomas Bechtold]

Explicitly set install-mode for kubelet daemon to enabled

[George Kraft (cynerva)]

Nice, I wasn't aware of this option. I actually think we would benefit from disabling this in the regular kubelet snap too. It would clean up the noisy logs in fresh deployments.

I'd like to test with `install-mode: disable` first to see if we can make that change safely.

[George Kraft (cynerva)]

I should be able to get to testing this next week. If it's needed more urgently, let me know.

[Thomas Bechtold (toabctl)]

We have a EKS bug that might be fixed with that. So if you could testing early next week, that would be great!

[Robby Pocase (rpocase)]

Just going through my TODOs - gentle bump on this post sprint. Not a major rush, but we hope to land the changes to our snap this pulse. If there is anything we can do to offload just let me know :).

[George Kraft (cynerva)]

I tested `install-mode: disable` today and found that it does cause problems for Charmed Kubernetes. The charms start the kubelet service, but they do not enable the service to start on boot. Given that this change would eventually make its way out to existing stable channels (1.27/stable, 1.26/stable, etc), we can't safely make the change until we revise our snap branching and release process to allow for a more controlled release.

The originally proposed change to add `install-mode: enable` for easier text substitution when building the kubelet-eks snap should be fine however. If you want to go that route then I will happily merge it. Just be careful in your bootstrap script to make sure you enable the service when you start it, maybe with `snap start --enable`.

[George Kraft (cynerva)]

review: Approve

diff --git a/snapcraft.yaml.in b/snapcraft.yaml.in
index 78894ec..a9ceb13 100644
--- a/snapcraft.yaml.in
+++ b/snapcraft.yaml.in
@@ -19,6 +19,7 @@ apps:
     command: wrappers/run-with-config-args wrappers/kubelet-wrapper
     daemon: simple
     restart-condition: always  # needed for Dynamic Kubelet Config support
+    install-mode: enable
   kubelet:
     command: kubelet