Merge lp:~toabctl/loco-team-portal/fixes-523709 into lp:loco-team-portal

Proposed by Thomas Bechtold
Status: Merged
Merged at revision: not available
Proposed branch: lp:~toabctl/loco-team-portal/fixes-523709
Merge into: lp:loco-team-portal
Diff against target: 438 lines (+93/-260)
7 files modified
loco_directory/media/css/common.css (+84/-0)
loco_directory/media/css/events.css (+0/-84)
loco_directory/media/css/style.css (+2/-0)
loco_directory/media/css/teams.css (+0/-85)
loco_directory/media/css/venues.css (+0/-84)
loco_directory/templates/404.html (+6/-3)
loco_directory/templates/base.html (+1/-4)
To merge this branch: bzr merge lp:~toabctl/loco-team-portal/fixes-523709
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Review via email: mp+19653@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Can you refresh this once lp:~toabctl/loco-directory/fix-523747 is fixed?

Revision history for this message
Daniel Holbach (dholbach) :
review: Needs Fixing
66. By Thomas Bechtold

fix urls for events and venues

67. By Thomas Bechtold

add . at the end of sentences

Revision history for this message
Thomas Bechtold (toabctl) wrote :

i don't know how to update the translations correct. please do that.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Good work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/media/css/common.css'
2--- loco_directory/media/css/common.css 2009-12-22 21:29:31 +0000
3+++ loco_directory/media/css/common.css 2010-02-20 12:38:16 +0000
4@@ -161,3 +161,87 @@
5 }
6
7
8+/* Stuff for the 3Dbox */
9+.box {
10+ background: #edf5e1;
11+ padding: 10px 20px 10px;
12+ position: relative;
13+ border-top: solid 2px #c4df9b;
14+}
15+
16+.dbox {
17+ position: absolute;
18+ padding: 0px;
19+ z-index: 0;
20+}
21+
22+.vert {
23+ top: 0px;
24+ height: 100%;
25+ background-repeat: repeat-y;
26+}
27+
28+.box-left {
29+ background-image: url(../img/box/left.png);
30+ left: -10px;
31+ width: 24px;
32+}
33+
34+.box-right {
35+ background-image: url(../img/box/right.png);
36+ right: -10px;
37+ width: 34px;
38+
39+}
40+
41+.horz {
42+ left: 0px;
43+ width: 100%;
44+ background-repeat: repeat-x;
45+}
46+
47+.box-top {
48+ background-image: url(../img/box/top.png);
49+ top: -10px;
50+ height: 24px;
51+}
52+
53+.box-bottom {
54+ background-image: url(../img/box/bottom.png);
55+ bottom: -10px;
56+ height: 34px;
57+}
58+
59+.box-top-left {
60+ background-image: url(../img/box/top-left.png);
61+ top: -10px;
62+ left: -10px;
63+ height: 24px;
64+ width: 24px;
65+}
66+
67+.box-top-right {
68+ background-image: url(../img/box/top-right.png);
69+ top: -10px;
70+ right: -10px;
71+ height: 24px;
72+ width: 34px;
73+}
74+
75+.box-bottom-left {
76+ background-image: url(../img/box/bottom-left.png);
77+ bottom: -10px;
78+ left: -10px;
79+ height: 34px;
80+ width: 24px;
81+}
82+
83+.box-bottom-right {
84+ background-image: url(../img/box/bottom-right.png);
85+ bottom: -10px;
86+ right: -10px;
87+ height: 34px;
88+ width: 34px;
89+}
90+
91+
92
93=== modified file 'loco_directory/media/css/events.css'
94--- loco_directory/media/css/events.css 2010-01-11 22:24:24 +0000
95+++ loco_directory/media/css/events.css 2010-02-20 12:38:16 +0000
96@@ -1,14 +1,6 @@
97 /*
98 * This CSS file is used to all pages dealing with Events
99 */
100-
101-.box {
102- background: #edf5e1;
103- padding: 10px 20px 10px;
104- position: relative;
105- border-top: solid 2px #c4df9b;
106-}
107-
108 th[scope="row"] {
109 text-align: right;
110 border: 0px solid red;
111@@ -112,79 +104,3 @@
112 background-image: url(../img/edit-delete.png)
113 }
114
115-.dbox {
116- position: absolute;
117- padding: 0px;
118- z-index: 0;
119-}
120-
121-.vert {
122- top: 0px;
123- height: 100%;
124- background-repeat: repeat-y;
125-}
126-
127-.box-left {
128- background-image: url(../img/box/left.png);
129- left: -10px;
130- width: 24px;
131-}
132-
133-.box-right {
134- background-image: url(../img/box/right.png);
135- right: -10px;
136- width: 34px;
137-
138-}
139-
140-.horz {
141- left: 0px;
142- width: 100%;
143- background-repeat: repeat-x;
144-}
145-
146-.box-top {
147- background-image: url(../img/box/top.png);
148- top: -10px;
149- height: 24px;
150-}
151-
152-.box-bottom {
153- background-image: url(../img/box/bottom.png);
154- bottom: -10px;
155- height: 34px;
156-}
157-
158-.box-top-left {
159- background-image: url(../img/box/top-left.png);
160- top: -10px;
161- left: -10px;
162- height: 24px;
163- width: 24px;
164-}
165-
166-.box-top-right {
167- background-image: url(../img/box/top-right.png);
168- top: -10px;
169- right: -10px;
170- height: 24px;
171- width: 34px;
172-}
173-
174-.box-bottom-left {
175- background-image: url(../img/box/bottom-left.png);
176- bottom: -10px;
177- left: -10px;
178- height: 34px;
179- width: 24px;
180-}
181-
182-.box-bottom-right {
183- background-image: url(../img/box/bottom-right.png);
184- bottom: -10px;
185- right: -10px;
186- height: 34px;
187- width: 34px;
188-}
189-
190-
191
192=== modified file 'loco_directory/media/css/style.css'
193--- loco_directory/media/css/style.css 2010-02-18 10:32:46 +0000
194+++ loco_directory/media/css/style.css 2010-02-20 12:38:16 +0000
195@@ -1,6 +1,8 @@
196 @import "common.css";
197 @import "layout.css";
198 @import "teams.css";
199+@import "venues.css";
200+@import "events.css";
201
202 body {
203 background-image: url(../img/bgrepeat.jpg);
204
205=== modified file 'loco_directory/media/css/teams.css'
206--- loco_directory/media/css/teams.css 2010-01-20 07:16:14 +0000
207+++ loco_directory/media/css/teams.css 2010-02-20 12:38:16 +0000
208@@ -1,14 +1,6 @@
209 /*
210 * This CSS file is used to all pages dealing with Teams
211 */
212-
213-.box {
214- background: #edf5e1;
215- padding: 10px 20px 10px;
216- position: relative;
217- border-top: solid 2px #c4df9b;
218-}
219-
220 .box .delete {
221 position: absolute;
222 top: 10px;
223@@ -190,80 +182,3 @@
224 width: 100%;
225 height: 90px;
226 }
227-
228-.dbox {
229- position: absolute;
230- padding: 0px;
231- z-index: 0;
232-}
233-
234-.vert {
235- top: 0px;
236- height: 100%;
237- background-repeat: repeat-y;
238-}
239-
240-.box-left {
241- background-image: url(../img/box/left.png);
242- left: -10px;
243- width: 24px;
244-}
245-
246-.box-right {
247- background-image: url(../img/box/right.png);
248- right: -10px;
249- width: 34px;
250-
251-}
252-
253-.horz {
254- left: 0px;
255- width: 100%;
256- background-repeat: repeat-x;
257-}
258-
259-.box-top {
260- background-image: url(../img/box/top.png);
261- top: -10px;
262- height: 24px;
263-}
264-
265-.box-bottom {
266- background-image: url(../img/box/bottom.png);
267- bottom: -10px;
268- height: 34px;
269-}
270-
271-.box-top-left {
272- background-image: url(../img/box/top-left.png);
273- top: -10px;
274- left: -10px;
275- height: 24px;
276- width: 24px;
277-}
278-
279-.box-top-right {
280- background-image: url(../img/box/top-right.png);
281- top: -10px;
282- right: -10px;
283- height: 24px;
284- width: 34px;
285-}
286-
287-.box-bottom-left {
288- background-image: url(../img/box/bottom-left.png);
289- bottom: -10px;
290- left: -10px;
291- height: 34px;
292- width: 24px;
293-}
294-
295-.box-bottom-right {
296- background-image: url(../img/box/bottom-right.png);
297- bottom: -10px;
298- right: -10px;
299- height: 34px;
300- width: 34px;
301-}
302-
303-
304
305=== modified file 'loco_directory/media/css/venues.css'
306--- loco_directory/media/css/venues.css 2010-02-18 10:32:46 +0000
307+++ loco_directory/media/css/venues.css 2010-02-20 12:38:16 +0000
308@@ -1,14 +1,6 @@
309 /*
310 * This CSS file is used to all pages dealing with Events
311 */
312-
313-.box {
314- background: #edf5e1;
315- padding: 10px 20px 10px;
316- position: relative;
317- border-top: solid 2px #c4df9b;
318-}
319-
320 th[scope="row"] {
321 text-align: right;
322 border: 0px solid red;
323@@ -67,79 +59,3 @@
324 background-image: url(../img/edit-team.png)
325 }
326
327-.dbox {
328- position: absolute;
329- padding: 0px;
330- z-index: 0;
331-}
332-
333-.vert {
334- top: 0px;
335- height: 100%;
336- background-repeat: repeat-y;
337-}
338-
339-.box-left {
340- background-image: url(../img/box/left.png);
341- left: -10px;
342- width: 24px;
343-}
344-
345-.box-right {
346- background-image: url(../img/box/right.png);
347- right: -10px;
348- width: 34px;
349-
350-}
351-
352-.horz {
353- left: 0px;
354- width: 100%;
355- background-repeat: repeat-x;
356-}
357-
358-.box-top {
359- background-image: url(../img/box/top.png);
360- top: -10px;
361- height: 24px;
362-}
363-
364-.box-bottom {
365- background-image: url(../img/box/bottom.png);
366- bottom: -10px;
367- height: 34px;
368-}
369-
370-.box-top-left {
371- background-image: url(../img/box/top-left.png);
372- top: -10px;
373- left: -10px;
374- height: 24px;
375- width: 24px;
376-}
377-
378-.box-top-right {
379- background-image: url(../img/box/top-right.png);
380- top: -10px;
381- right: -10px;
382- height: 24px;
383- width: 34px;
384-}
385-
386-.box-bottom-left {
387- background-image: url(../img/box/bottom-left.png);
388- bottom: -10px;
389- left: -10px;
390- height: 34px;
391- width: 24px;
392-}
393-
394-.box-bottom-right {
395- background-image: url(../img/box/bottom-right.png);
396- bottom: -10px;
397- right: -10px;
398- height: 34px;
399- width: 34px;
400-}
401-
402-
403
404=== modified file 'loco_directory/templates/404.html'
405--- loco_directory/templates/404.html 2010-02-15 17:01:55 +0000
406+++ loco_directory/templates/404.html 2010-02-20 12:38:16 +0000
407@@ -11,9 +11,12 @@
408
409
410 <div class="main">
411- <h2><a href="{% url team-list %}">{% trans "You can browse the full list of teams" %}</a></h2>
412- <p>{% trans "If you believe the reason you are here is a bug in the LoCo Directory please " %} <a href='https://bugs.launchpad.net/loco-directory'>{% trans "Report it!" %}</a>
413- </p>
414+ <ul>
415+ <li><a href="{% url team-list %}">{% trans "You can browse the full list of teams." %}</a></li>
416+ <li><a href="{% url event-list %}">{% trans "You can browse the full list of events." %}</a></li>
417+ <li><a href="{% url venue-list %}">{% trans "You can browse the full list of venues." %}</a></li>
418+ </ul>
419+ <p>{% trans "If you believe the reason you are here is a bug in the LoCo Directory please " %} <a href='https://bugs.launchpad.net/loco-directory'>{% trans "Report it!" %}</a></p>
420 </div>
421 <div class="clear"></div>
422 </div><!-- container -->
423
424=== modified file 'loco_directory/templates/base.html'
425--- loco_directory/templates/base.html 2010-02-18 19:21:08 +0000
426+++ loco_directory/templates/base.html 2010-02-20 12:38:16 +0000
427@@ -5,11 +5,8 @@
428 <head>
429 <meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
430 <title>{% block title %} {% trans "Ubuntu LoCo Team Directory" %} {% endblock %}</title>
431- <link rel="stortcut icon" href="/media/img/favicon.ico" type="image/x-icon" />
432+ <link rel="shortcut icon" href="/media/img/favicon.ico" type="image/x-icon" />
433 <style type="text/css" media="all">@import "/media/css/style.css";</style>
434- <link rel="stylesheet" href="/media/css/teams.css" type="text/css" media="screen" />
435- <link rel="stylesheet" href="/media/css/events.css" type="text/css" media="screen" />
436- <link rel="stylesheet" href="/media/css/venues.css" type="text/css" media="screen" />
437 <script src="http://maps.google.com/maps?file=api&amp;v=2&amp;key=ABQIAAAAzr2EBOXUKnm_jVnk0OJI7xSosDVG8KKPE1-m51RBrvYughuyMxQ-i1QfUnH94QxWIa6N4U6MouMmBA" type="text/javascript"></script>
438 <script type="text/javascript">
439

Subscribers

People subscribed via source and target branches