Merge lp:~tmaesaka/drizzle/drizzle-fix-drizzleslap into lp:~drizzle-trunk/drizzle/development
Proposed by
Toru Maesaka
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~tmaesaka/drizzle/drizzle-fix-drizzleslap |
Merge into: | lp:~drizzle-trunk/drizzle/development |
Diff against target: | None lines |
To merge this branch: | bzr merge lp:~tmaesaka/drizzle/drizzle-fix-drizzleslap |
Related bugs: | |
Related blueprints: |
HTTP Protocol Plugin
(Low)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brian Aker | Needs Resubmitting | ||
Jay Pipes (community) | Approve | ||
Stewart Smith (community) | Approve | ||
Review via email:
|
To post a comment you must log in.
This merge involves three fixes:
(1) There was a block of code that assumed memory allocation
is always successful so a check is added.
(2) Fix a segmentation fault that is caused due to
trying to free a invalid pointer in statement_clean().
Note: This fix is not perfect.
Ideally, we should move the query_statement list to
a proper container like std::vector and create a
nice cleanup function for it (which I'm planning to
do next). This way, we can get rid of the small
memory leak that has been in drizzleslap for a while.
(3) Fix a memory leak due to not freeing the string
obtained inside my_open(). So, use my_close() instead
of directly closing the descriptor with close(2).
Cheers,
Toru