Code review comment for lp:~tkluck/ubuntu/oneiric/goocanvas/v2

Hi, thanks for your work on this. Next time, please consider subscribing ubuntu-sponsors to your bug report when you feel that your packaging work is ready to go into Ubuntu. Launchpad is so huge that it's easy for useful contributions to go unseen if they don't show up in the right places!

I wasn't able to build this. First, because of:

usr/bin/make -f debian/rules reverse-config
make[1]: Entering directory `/home/jeremy/devel/goocanvas/build-area/goocanvas-2.0.0'
/usr/share/cdbs/1/rules/dpatch.mk:33: WARNING: dpatch.mk is deprecated - please use source format 3.0 (quilt) instead
for i in ./config.guess ./config.sub ; do \
  if test -e $i.cdbs-orig ; then \
   mv $i.cdbs-orig $i ; \
  fi ; \
 done
make[1]: Leaving directory `/home/jeremy/devel/goocanvas/build-area/goocanvas-2.0.0'
dpatch deapply-all
make: dpatch: Command not found
make: *** [deapply-dpatches] Error 127
E: Failed to clean source directory
bzr: ERROR: The build failed.

After removing the dpatch line from debian/rules I got quite a few errors about modified upstream files. I don't think you meant to be modifying upstream.

1. Remove the dpatch line from debian/rules
2. Cleanly extract the upstream tarball
3. Please also fix this lintian warning:
libgoocanvas-2.0: package-name-doesnt-match-sonames libgoocanvas-2.0-9