Merge lp:~tkluck/postler/contact-parsing into lp:postler
Status: | Needs review | ||||||||
---|---|---|---|---|---|---|---|---|---|
Proposed branch: | lp:~tkluck/postler/contact-parsing | ||||||||
Merge into: | lp:postler | ||||||||
Diff against target: |
356 lines (+137/-99) 7 files modified
postler/postler-bureau.vala (+1/-1) postler/postler-contact.vala (+55/-23) postler/postler-content.vala (+2/-2) postler/postler-index.vala (+1/-1) postler/postler-message.vala (+23/-14) postler/postler-messages.vala (+54/-57) postler/postler-recipiententry.vala (+1/-1) |
||||||||
To merge this branch: | bzr merge lp:~tkluck/postler/contact-parsing | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cris Dywan | Pending | ||
Review via email: mp+67378@code.launchpad.net |
Description of the change
This branch should fix 3 bugs:
* Bug #804018: Difficulties with recipient parsing
* Bug #806450: multi-line fields are not parsed correctly
* a bug that I haven't reported where parsing encoded text can hang inside g_utf8_
I cannot reproduce the last bug anymore, so I guess it only happened with invalid encoded text (which may have resulted from the previous bug). Still, my new implementation using regular expressions is simpler and therefore hopefully more robust. Please review.
Unmerged revisions
- 909. By Timo Kluck
-
merge trunk
- 908. By Timo Kluck
-
merge trunk
- 907. By Timo Kluck
-
merge trunk
- 906. By Timo Kluck
-
merge trunk
- 905. By Timo Kluck
-
merge trunk
- 904. By Timo Kluck
-
merge trunk
- 903. By Timo Kluck
-
merge trunk
- 902. By Timo Kluck
-
merge trunk
- 901. By Timo Kluck
-
merge trunk
- 900. By Timo Kluck
-
* no cuddled brackets
* fix build warnings
* fix bug with not breaking header parsing at empty line