Merge lp:~tj/ubuntu/trusty/grub-installer/lp1354730 into lp:ubuntu/trusty/grub-installer
Proposed by
TJ
on 2014-08-10
| Status: | Rejected |
|---|---|
| Rejected by: | Mathieu Trudel-Lapierre on 2015-04-03 |
| Proposed branch: | lp:~tj/ubuntu/trusty/grub-installer/lp1354730 |
| Merge into: | lp:ubuntu/trusty/grub-installer |
| Diff against target: |
27 lines (+8/-1) 2 files modified
debian/changelog (+7/-0) grub-installer (+1/-1) |
| To merge this branch: | bzr merge lp:~tj/ubuntu/trusty/grub-installer/lp1354730 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre | 2014-08-10 | Disapprove on 2015-04-03 | |
| Colin Watson | 2014-09-29 | Needs Fixing on 2015-01-06 | |
|
Review via email:
|
|||
Description of the Change
Fix installer failure due to grub-probe returning more than one device in the case of BTRS multi-disk RAID volumes.
To post a comment you must log in.
| Colin Watson (cjwatson) wrote : | # |
| Colin Watson (cjwatson) wrote : | # |
Oh, also, the version number will need to be 1.78ubuntu20.1 rather than 1.78ubuntu21. You can see from https:/
review:
Needs Fixing
| Mathieu Trudel-Lapierre (cyphermox) wrote : | # |
It looks like this was in fact breaking grub-installer in some cases in vivid; rejecting. Details are on the bug report.
review:
Disapprove


12:51 <seb128> cjwatson, hey, do you think you could review https:/ /code.launchpad .net/~tj/ ubuntu/ trusty/ grub-installer/ lp1354730/ +merge/ 230222 or maybe suggest somebody who could? that's a one line and is in the sponsoring queue since august
12:52 <cjwatson> seb128: It needs to go into a branch based on lp:~ubuntu-core-dev/grub-installer/ubuntu (except branched for trusty), rather than using the unused UDD branch. But I'm not doing d-i stuff now in general; maybe slangasek can suggest somebody.
12:52 <cjwatson> (Oh and it should use head -n1 not head -1 on general principles)